feat: Add DRM video download support #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PruthiviRaj27
commented
Nov 11, 2024
•
PruthiviRaj27
commented
- This commit introduces the functionality to download and play DRM-protected videos.
Karthik-0
reviewed
Nov 15, 2024
Comment on lines
43
to
46
| // TPStreamsSDK.provider.API.getAsset(assetID, accessToken) { [weak self] asset, error in | ||
| // guard let self = self else { return } | ||
| // if let asset = asset { | ||
| // //TODO Create video quality object (dummy for now, can be implemented later) | ||
| // let videoQuality = VideoQuality.init(resolution: resolution, bitrate: 4611200) | ||
| // startDownload(asset: asset, videoQuality: videoQuality) | ||
| // } else if let error = error{ | ||
| // print (error) | ||
| // } | ||
| // } | ||
| } |
There was a problem hiding this comment.
Why these are commented out?
PruthiviRaj27
force-pushed
the
add_drm_offline_download_support
branch
from
12c504b to
1f7d0e0
Compare
PruthiviRaj27
force-pushed
the
add_drm_offline_download_support
branch
from
1f7d0e0 to
a705347
Compare
Karthik-0
approved these changes
Nov 19, 2024
Karthik-0
reviewed
Nov 21, 2024
Source/Utils/M3U8Util.swift
Outdated
| import Foundation | ||
| import M3U8Parser | ||
|
|
||
| public class M3U8ParseUtil { |
There was a problem hiding this comment.
Suggested change
| public class M3U8ParseUtil { | |
| public class M3U8Parser { |
Karthik-0
reviewed
Nov 21, 2024
Source/Utils/M3U8Util.swift
Outdated
|
|
||
| public class M3U8ParseUtil { | ||
|
|
||
| static func extractContentIDFromMasterURL(masterURL: URL, completion: @escaping (Result<String, Error>) -> Void) { |
There was a problem hiding this comment.
Suggested change
| static func extractContentIDFromMasterURL(masterURL: URL, completion: @escaping (Result<String, Error>) -> Void) { | |
| static func extractContentID(url: URL, completion: @escaping (Result<String, Error>) -> Void) { |
Karthik-0
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.