Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forkchoiceupdated hang #121

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Fix forkchoiceupdated hang #121

merged 3 commits into from
Jan 17, 2024

Conversation

ImTei
Copy link
Member

@ImTei ImTei commented Jan 15, 2024 •
edited
Loading

  • Re-enable timeout for forkChoiceUpdated API, but return an error instead of SYNCING.
  • op-node does not handle SYNCING as asynchronous forkChoiceUpdated. So error will make op-node retry engine API.
  • Do not update latest tag if the version is RC.

@ImTei ImTei requested a review from pcw109550 January 15, 2024 06:40
@ImTei ImTei force-pushed the fix-forkchoiceupdated-hang branch 2 times, most recently from 9f2dfa8 to 3795fd8 Compare January 15, 2024 07:12
@ImTei ImTei force-pushed the fix-forkchoiceupdated-hang branch from 3795fd8 to b788d7a Compare January 15, 2024 07:29
@ImTei ImTei merged commit 5f570c2 into op-erigon Jan 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcw109550 pcw109550 pcw109550 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImTei @pcw109550