Minimal docker compose support #407
Conversation
|
Thank you for opening this PR! Unfortunately, I don't have the bandwidth at the moment to shepherd this. I have not put a lot of thought into how docker compose support should look like from an API PoV. Given that it is mostly additions, I don't expect many merge conflicts here so I'll just leave this open until either myself or another maintainer has the bandwidth to look into this. I hope you understand :) |
| self.pull().expect("Failed to execute docker compose pull"); | ||
|
|
||
| let mut cmd = self.cmd(); | ||
| cmd.args(["up"]); |
There was a problem hiding this comment.
Maybe add some sort of up policy to handle --no-recreate --detach
|
|
||
| fn pull(&self) -> Result<(), std::io::Error> { | ||
| let mut cmd = self.cmd(); | ||
| cmd.args(["pull"]); |
There was a problem hiding this comment.
In the case of not self.inherit_io, we need to prevent logs like it's done in the up()
|
Are there any plans to review this? |
I am afraid I don't have the bandwidth to review this at the moment. If somebody can write up a high-level design on how this is meant to work, I can give some input :) |
|
Already done in rustainers. |
|
@IgorLaborieWefox I like your code so much. It's great, can I use this PR code for my new crate. I'm planning release a crate for dockers compose test |
|
@longdt I suggest you have a look at rustainers. It's implemented by the same team in a similar approach, maybe you can use it as is :) |
|
Just informing everyone interested, we are doing a major revision of |
Add a minimal
docker composesupport.See #59
The code is behind the
composefeature.It requires having a
docker composev2.x.x installed