Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the default COS instance name that is used by the DA #290

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

ocofaigh
Copy link
Member

Description

fix for terraform-ibm-modules/dev-rag#40

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Member Author

Upgrade test failed (as expected) with this update:

        	Messages:   	Resource(s) identified to be updated 
        	            	Name: cos_instance
        	            	Address: module.cos[0].ibm_resource_instance.cos_instance[0]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"name":"base-security-services-cos"}
        	            	  After: 
        	            		{"name":"base-event-notifications-cos"}

No impact to the service itself, so fine to skip test

@ocofaigh
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Member Author

Issues creating CBRs:

2024/09/12 16:18:31 Terraform apply | Error: context deadline exceeded
 2024/09/12 16:18:31 Terraform apply | 
 2024/09/12 16:18:31 Terraform apply |   with module.cbr_vpc_zone.ibm_cbr_zone.cbr_zone,
 2024/09/12 16:18:31 Terraform apply |   on .terraform/modules/cbr_vpc_zone/modules/cbr-zone-module/main.tf line 7, in resource "ibm_cbr_zone" "cbr_zone":
 2024/09/12 16:18:31 Terraform apply |    7: resource "ibm_cbr_zone" "cbr_zone" {
 2024/09/12 16:18:31 Terraform apply | 
 2024/09/12 16:18:31 Terraform apply | 
 2024/09/12 16:18:31 Terraform apply | Error: context deadline exceeded
 2024/09/12 16:18:31 Terraform apply | 
 2024/09/12 16:18:31 Terraform apply |   with module.cbr_zone_schematics.ibm_cbr_zone.cbr_zone,
 2024/09/12 16:18:31 Terraform apply |   on .terraform/modules/cbr_zone_schematics/modules/cbr-zone-module/main.tf line 7, in resource "ibm_cbr_zone" "cbr_zone":
 2024/09/12 16:18:31 Terraform apply |    7: resource "ibm_cbr_zone" "cbr_zone" {

Unrelated to code in this PR, so re-running..

@ocofaigh
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 21fad7a into main Sep 12, 2024
2 checks passed
@ocofaigh ocofaigh deleted the ocofaigh-patch-1 branch September 12, 2024 17:27
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.10.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants