Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to use custom security groups #348

Merged
merged 11 commits into from
Feb 6, 2025
Merged

feat: add support to use custom security groups #348

merged 11 commits into from
Feb 6, 2025

Conversation

akocbek
Copy link
Contributor

@akocbek akocbek commented Jan 20, 2025

Description

#338

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@akocbek
Copy link
Contributor Author

akocbek commented Jan 20, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 20, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 20, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 21, 2025

/run pipeline

1 similar comment
@akocbek
Copy link
Contributor Author

akocbek commented Jan 21, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 23, 2025

/run pipeline

2 similar comments
@akocbek
Copy link
Contributor Author

akocbek commented Jan 23, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 23, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 24, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 24, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 24, 2025

/run pipeline

@toddgiguere
Copy link

/run pipeline

3 similar comments
@akocbek
Copy link
Contributor Author

akocbek commented Jan 27, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 28, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 28, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jan 29, 2025

Error: [0m Error: [ERROR] VPNServer failed Error Getting VPC Server: Get "https://jp-tok.iaas.cloud.ibm.com/v1/vpn_servers/r022-2e81c51e-d305-4b57-94ce-b9bdb954f56a?generation=2&version=2024-12-17": context deadline exceeded
│ null
│ 
│ 
│ 
│   with module.vpn.ibm_is_vpn_server.vpn,
│   on ../../main.tf line 58, in resource "ibm_is_vpn_server" "vpn":
│   58: resource "ibm_is_vpn_server" "vpn" {
│ 
╵}

@akocbek
Copy link
Contributor Author

akocbek commented Jan 29, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 5692b85 into main Feb 6, 2025
2 checks passed
@ocofaigh ocofaigh deleted the default_sg branch February 6, 2025 10:18
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants