Uplift MLIR, add slice tests. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPanosTT
force-pushed
the
lpanos/slice_tests
branch
from
00fe305 to
7fb08e8
Compare
LPanosTT
requested review from
AleksKnezevic,
mmanzoorTT,
uazizTT and
ddilbazTT
uazizTT
force-pushed
the
main
branch
5 times, most recently
from
382cfe2 to
89c288d
Compare
LPanosTT
force-pushed
the
lpanos/slice_tests
branch
from
57a76c4 to
e154344
Compare
LPanosTT
force-pushed
the
lpanos/slice_tests
branch
3 times, most recently
from
6aade23 to
476e891
Compare
uazizTT
force-pushed
the
main
branch
2 times, most recently
from
d6cb7d5 to
1a4da93
Compare
mmanzoorTT
reviewed
Oct 29, 2024
tt_torch/csrc/tt-mlir-interface.cpp
Outdated
| @@ -69,14 +73,16 @@ tt::runtime::Binary Compile(std::string_view code) { | |||
| mlir::ParserConfig{&context, /*verifyAfterParse=*/true}); | |||
|
|
|||
| mlir_module->dump(); | |||
|
|
|||
LPanosTT
force-pushed
the
lpanos/slice_tests
branch
from
476e891 to
9645072
Compare
ddilbazTT
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for
sliceand uplifted MLIRThe MLIR uplift required a few more register calls and using implicit nesting in the pass manager rather than the default explicit. I chose to do this because the pass manager used by
ttmlir-opthas implicit nesting and is able to run the tests we otherwise wouldn't be able to here.