Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ttnn parser and ttnn ops md files [#26] #35

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

ddilbazTT
Copy link
Contributor

No description provided.

@ddilbazTT
Copy link
Contributor Author

ddilbazTT commented Nov 13, 2024

Sorry I'm not writing Input and output shapes correctly. Will fix this

Copy link
Contributor

@AleksKnezevic AleksKnezevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the code to generate the md files?

Copy link

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @ddilbazTT!

@AleksKnezevic @nsmithtt it'll be good to think about have similar type of logic on TTNN level (directly in MLIR).

More precisely, from the Forge-FE use case, this approach is okay if ops are mapped 1:1. However, that often isn't the case as many ops will be decomposed into multiple ones. Therefore, mapping our ops to single TTNN ops will not be feasible.

However, if we have something on the TTNN level it'll be a great help for each frontend. More precisely, when a model is compiled through MLIR, we're getting TTNN graphs (flatbuffer binary). If we have the mechanism to split that TTNN into unique ops, and run each of them separately and generate these markdowns, we'll have a solution for each frontend down the like. Therefore, if you have time please think about this approach as well :))

That said, from Forge-FE perspective I still need e2e approach comingfrom Forge-FE, as I can hit many issues before we even generate TTIR and then TTNN. So my main priority is to stabilize our model analysis that will focus on framework ops, rather than pure TTNN ops. However, if anyone from Forge team is available, it'll be good to explore this approach as well in parallel while we're pushing custom solutions through each frontend.

Let me know your thoughts.

@ddilbazTT ddilbazTT enabled auto-merge (squash) November 14, 2024 17:01
@ddilbazTT ddilbazTT merged commit a70eb25 into main Nov 14, 2024
4 checks passed
@ddilbazTT ddilbazTT deleted the ddilbaz/parse_ttnn branch November 14, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants