Added logic for deleting nodes - need review #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddilbazTT
force-pushed
the
ddilbaz/delete_nodes
branch
from
be97884 to
c252afb
Compare
AleksKnezevic
requested changes
Nov 6, 2024
ddilbazTT
force-pushed
the
ddilbaz/delete_nodes
branch
3 times, most recently
from
26ae272 to
cadf6d3
Compare
ddilbazTT
force-pushed
the
ddilbaz/delete_nodes
branch
from
cadf6d3 to
d244633
Compare
|
Updated the code based on remarks - @AleksKnezevic can you let me know if i should merge? |
AleksKnezevic
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aleks, can you let me know if this is what you had mind?