Add tests for logical operations #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mmanzoorTT
commented
Oct 31, 2024
•
mmanzoorTT
commented
- Update backend to convert unsupported types to supported types for hardware
- Update testing infrastructure to generate boolean inputs
- Add tests for logical operations (and, not, or, xor)
mmanzoorTT
requested review from
AleksKnezevic,
LPanosTT,
uazizTT and
ddilbazTT
mmanzoorTT
force-pushed
the
mmanzoor/logical-tests
branch
3 times, most recently
from
8b13262 to
fe2cf05
Compare
mmanzoorTT
force-pushed
the
mmanzoor/logical-tests
branch
from
fe2cf05 to
6e889cc
Compare
| @@ -314,6 +314,14 @@ def run_gm_op_by_op(self, *inputs): | |||
| return outputs | |||
|
|
|||
| def __call__(self, *inputs): | |||
| new_inputs = () | |||
There was a problem hiding this comment.
I'm sure we'll need more of these conversions. Can you make a dict outside of the scope of this function that makes it clear what we're converting to what?
There was a problem hiding this comment.
Thanks for the suggestion. I have added a dictionary for type conversions. Currently, I am only adding boolean->bflaot16; we can add more type conversions later. We only need to add entries in the dictionary.
mmanzoorTT
force-pushed
the
mmanzoor/logical-tests
branch
3 times, most recently
from
8ed2f62 to
6efc4a7
Compare
* Logical and * Logical or * Logical not * Logical xor
mmanzoorTT
force-pushed
the
mmanzoor/logical-tests
branch
from
6efc4a7 to
4a2baba
Compare
AleksKnezevic
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.