Add mamba tests [#75] #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddilbazTT
requested review from
AleksKnezevic,
LPanosTT,
mmanzoorTT and
uazizTT
LPanosTT
approved these changes
Dec 16, 2024
mmanzoorTT
approved these changes
Dec 16, 2024
| @pytest.mark.parametrize( | ||
| "model_name", | ||
| [ | ||
| "state-spaces/mamba-790m-hf", |
There was a problem hiding this comment.
Does all these four models fail with same error/location?
There was a problem hiding this comment.
Is the generated graph the full model?
ddilbazTT
force-pushed
the
ddilbaz/mamba
branch
from
415cc93 to
93e5874
Compare
Add tests for mamba and mamba2. Tests are marked xfail because they yield 'AssertionError: Attempt to trace forbidden callable <function mark_static_address at 0x744a0d11d3a0>' error. However, the tests generate a graph.
ddilbazTT
force-pushed
the
ddilbaz/mamba
branch
from
93e5874 to
15fb194
Compare
…ly when trying to handle conv_states with mark_static_address. The fixes were recommended by gpt so needs more research, yet the models are passing as of now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for mamba and mamba2. Tests are marked xfail because they yield 'AssertionError: Attempt to trace forbidden callable <function mark_static_address at 0x744a0d11d3a0>' error. However, the tests generate a graph.