Uplift third_party/tt-metal to 182c42462cd61515f60a11a46ee84f303ed073ee 2025-01-23 #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmithtt
approved these changes
Jan 23, 2025
brataTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic,
pilkicTT and
tapspatel
as code owners
brataTT
force-pushed
the
uplift
branch
2 times, most recently
from
3176c23 to
80bc95b
Compare
brataTT
requested review from
svuckovicTT,
mtopalovicTT,
azecevicTT and
jserbedzijaTT
as code owners
kmabeeTT
reviewed
Jan 23, 2025
.github/Dockerfile.base
Outdated
| @@ -39,7 +39,8 @@ RUN wget https://apt.llvm.org/llvm.sh && \ | |||
| ./llvm.sh 17 && \ | |||
| apt install -y libc++-17-dev libc++abi-17-dev && \ | |||
| ln -s /usr/bin/clang-17 /usr/bin/clang && \ | |||
| ln -s /usr/bin/clang++-17 /usr/bin/clang++ | |||
| ln -s /usr/bin/clang++-17 /usr/bin/clang++ && \ | |||
| ln -s /usr/bin/clang-scan-deps-17 /usr/bin/clang-scan-deps | |||
There was a problem hiding this comment.
Don't love this change (is it also needed for dockers outside CI?), what is it fixing? Include path updates make sense and are typical for missing headers though, I like that part.
There was a problem hiding this comment.
I'm getting an error CMAKE_CXX_COMPILER_CLANG_SCAN_DEPS-NOTFOUND when building locally and in CI after the metal cmake change
This does fix it locally.
I also tried adding the cmake flag directly, but that didn't work for some reason.
I assume we get this error because something upstream is using scan deps. Probably the json dep update since it's been years between the updated and prev version.
brataTT
force-pushed
the
uplift
branch
2 times, most recently
from
ab65fac to
70cf4a4
Compare
azecevicTT
reviewed
Jan 23, 2025
| @@ -81,7 +81,7 @@ createOwnedTensor(std::shared_ptr<void> data, | |||
|
|
|||
| return ::ttnn::Tensor( | |||
| createStorage<OwnedStorage>(data.get(), numElements, dataType), | |||
| ::ttnn::Shape(small_vector_shape), utils::toTTNNDataType(dataType), | |||
| ::ttnn::SimpleShape(small_vector_shape), utils::toTTNNDataType(dataType), | |||
There was a problem hiding this comment.
Last month explicit ShapeBase(std::span<const uint32_t>) was added, we can now use ::ttnn::SimpleShape(shape) directly.
There was a problem hiding this comment.
Thanks for noticing 🙏
I'll make the change.
…-DCMAKE_CXX_SCAN_FOR_MODULES=FALSE - Solves CMAKE_CXX_COMPILER_CLANG_SCAN_DEPS-NOTFOUND error
|
Brings 31 tt-metal commits.
|
|
I paused tt-metal auto-uplifts so the 1am job didn't destroy this branch to let above tt-torch CI finish. Now that it finished, going to merge this and we'll kick off another auto uplift, can include the suggested Shape change on next one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uplifts the third_party/tt-metal to the 182c42462cd61515f60a11a46ee84f303ed073ee