Tighten implicit broadcast constraints for multiplyOp and maximumOp f… #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or lack of support. Refactor repeat tests.
uazizTT
requested review from
sdjordjevicTT,
nsmithtt,
svuckovicTT,
mtopalovicTT,
mrakitaTT,
jserbedzijaTT and
azecevicTT
as code owners
brataTT
approved these changes
Jan 21, 2025
uazizTT
force-pushed
the
uaziz/repeat-improvements
branch
from
4cd0377 to
315af52
Compare
|
Can someone please give a quick review to this small change as it is blocking tt-torch uplift. |
AleksKnezevic
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Can you move this file using git mv? This should be represented in git history as a rename, not a delete + new file...
Or even better, don't move it at all, I grouped all data_movement ops tests under a single place in this PR:
#1941
sdjordjevicTT
approved these changes
Jan 23, 2025
kmabeeTT
pushed a commit
that referenced
this pull request
Jan 24, 2025
#1919) …or lack of support. Refactor repeat tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or lack of support. Refactor repeat tests.