Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Add controller kernel to sync the producers #17629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aagarwalTT
Copy link
Contributor

@aagarwalTT aagarwalTT commented Feb 5, 2025

Ticket

Link to Github Issue

Problem description

Currently the producer kernels wait for the signal from host to start transmitting packets. This could cause the workers to transmit the packets in non-overlapping time frames thus impacting perf calculations. This could get as worse as the workers running serially because of fabric not allowing context switch for the slow dispatch commands to go through.

What's changed

Add a new controller kernel that now synchronizes all the producers on the same chip. This kernel now waits for the signal from the host and then noc mcasts the notification to the worker kernels, thus reducing the skew to the order of 10s of cycles. This kernel can be extended to setup other handshakes in the future as well.

Checklist

@aagarwalTT aagarwalTT requested a review from ubcheema as a code owner February 5, 2025 22:53
@aagarwalTT aagarwalTT force-pushed the aagarwal/test-updates-pt2 branch from 06d20c5 to fa0b049 Compare February 5, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants