Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Fix NCRISC delay #17526

Merged
merged 1 commit into from
Feb 4, 2025
Merged

#0: Fix NCRISC delay #17526

merged 1 commit into from
Feb 4, 2025

Conversation

jbaumanTT
Copy link
Contributor

@jbaumanTT jbaumanTT commented Feb 4, 2025

What's changed

The current KERNEL_RUN_TIME code was ignoring end_time and instead delaying an arbitrary amount. Instead match the code for other kernels and wait for the correct amount of time.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

The current KERNEL_RUN_TIME code was ignoring end_time and instead delaying an arbitrary amount.
@jbaumanTT jbaumanTT merged commit d825201 into main Feb 4, 2025
192 of 195 checks passed
@jbaumanTT jbaumanTT deleted the jbauman/fixncrisctime branch February 4, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants