-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add perf report for reduce scatter async #17223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aswinmcw
force-pushed
the
Aswinmcw/reduce_scatter_async_perf
branch
from
January 28, 2025 12:11
46e2917
to
1fec994
Compare
SeanNijjar
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
"per_chip_output_shape, dim, layout", | ||
[ | ||
([1, 1, 32, 32], 3, ttnn.TILE_LAYOUT), | ||
# ([1, 1, 32, 32 * 2], 3, ttnn.TILE_LAYOUT), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the commented shapes
Aswinmcw
force-pushed
the
Aswinmcw/ccl_async_perf
branch
from
January 29, 2025 07:22
20de603
to
7e1705f
Compare
Aswinmcw
force-pushed
the
Aswinmcw/reduce_scatter_async_perf
branch
from
January 29, 2025 07:23
1fec994
to
113b8eb
Compare
Aswinmcw
force-pushed
the
Aswinmcw/ccl_async_perf
branch
from
January 30, 2025 05:07
7e1705f
to
d51707d
Compare
Aswinmcw
force-pushed
the
Aswinmcw/reduce_scatter_async_perf
branch
from
January 30, 2025 08:07
08246d6
to
cc79106
Compare
williamlyTT
pushed a commit
that referenced
this pull request
Jan 30, 2025
### Ticket #16648 ### Problem description Provide context for the problem. ### What's changed <img width="1299" alt="Screenshot 2025-01-28 at 5 41 07 PM" src="https://github.com/user-attachments/assets/4c9353a0-d001-470d-8417-56cccb661ddd" /> ### Checklist - [ ] Post commit CI passes - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [ ] New/Existing tests provide coverage for changes
yieldthought
pushed a commit
that referenced
this pull request
Jan 31, 2025
### Ticket #16648 ### Problem description Provide context for the problem. ### What's changed <img width="1299" alt="Screenshot 2025-01-28 at 5 41 07 PM" src="https://github.com/user-attachments/assets/4c9353a0-d001-470d-8417-56cccb661ddd" /> ### Checklist - [ ] Post commit CI passes - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [ ] New/Existing tests provide coverage for changes
nikileshx
pushed a commit
to nikileshx/tt-metal
that referenced
this pull request
Feb 3, 2025
### Ticket tenstorrent#16648 ### Problem description Provide context for the problem. ### What's changed <img width="1299" alt="Screenshot 2025-01-28 at 5 41 07 PM" src="https://github.com/user-attachments/assets/4c9353a0-d001-470d-8417-56cccb661ddd" /> ### Checklist - [ ] Post commit CI passes - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [ ] New/Existing tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#16648
Problem description
Provide context for the problem.
What's changed
Checklist