Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perf report for reduce scatter async #17223

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

Aswinmcw
Copy link
Contributor

@Aswinmcw Aswinmcw commented Jan 28, 2025

Ticket

#16648

Problem description

Provide context for the problem.

What's changed

Screenshot 2025-01-28 at 5 41 07 PM

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@Aswinmcw Aswinmcw force-pushed the Aswinmcw/reduce_scatter_async_perf branch from 46e2917 to 1fec994 Compare January 28, 2025 12:11
Copy link
Contributor

@SeanNijjar SeanNijjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"per_chip_output_shape, dim, layout",
[
([1, 1, 32, 32], 3, ttnn.TILE_LAYOUT),
# ([1, 1, 32, 32 * 2], 3, ttnn.TILE_LAYOUT),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the commented shapes

@Aswinmcw Aswinmcw force-pushed the Aswinmcw/ccl_async_perf branch from 20de603 to 7e1705f Compare January 29, 2025 07:22
@Aswinmcw Aswinmcw force-pushed the Aswinmcw/reduce_scatter_async_perf branch from 1fec994 to 113b8eb Compare January 29, 2025 07:23
@Aswinmcw Aswinmcw force-pushed the Aswinmcw/ccl_async_perf branch from 7e1705f to d51707d Compare January 30, 2025 05:07
Base automatically changed from Aswinmcw/ccl_async_perf to main January 30, 2025 08:03
@Aswinmcw Aswinmcw force-pushed the Aswinmcw/reduce_scatter_async_perf branch from 08246d6 to cc79106 Compare January 30, 2025 08:07
@Aswinmcw Aswinmcw marked this pull request as ready for review January 30, 2025 08:20
@Aswinmcw Aswinmcw merged commit 4274236 into main Jan 30, 2025
229 of 236 checks passed
@Aswinmcw Aswinmcw deleted the Aswinmcw/reduce_scatter_async_perf branch January 30, 2025 09:15
williamlyTT pushed a commit that referenced this pull request Jan 30, 2025
### Ticket
#16648 

### Problem description
Provide context for the problem.

### What's changed

<img width="1299" alt="Screenshot 2025-01-28 at 5 41 07 PM"
src="https://github.com/user-attachments/assets/4c9353a0-d001-470d-8417-56cccb661ddd"
/>


### Checklist
- [ ] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [ ] New/Existing tests provide coverage for changes
yieldthought pushed a commit that referenced this pull request Jan 31, 2025
### Ticket
#16648 

### Problem description
Provide context for the problem.

### What's changed

<img width="1299" alt="Screenshot 2025-01-28 at 5 41 07 PM"
src="https://github.com/user-attachments/assets/4c9353a0-d001-470d-8417-56cccb661ddd"
/>


### Checklist
- [ ] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [ ] New/Existing tests provide coverage for changes
nikileshx pushed a commit to nikileshx/tt-metal that referenced this pull request Feb 3, 2025
### Ticket
tenstorrent#16648 

### Problem description
Provide context for the problem.

### What's changed

<img width="1299" alt="Screenshot 2025-01-28 at 5 41 07 PM"
src="https://github.com/user-attachments/assets/4c9353a0-d001-470d-8417-56cccb661ddd"
/>


### Checklist
- [ ] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [ ] New/Existing tests provide coverage for changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants