Removing skip_for_blackhole and fix some minor issues for blackhole conv2d #17222
+21
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -578,7 +579,7 @@ def test_conv_ws( | |||
| auto_shard, | |||
| tilized_input, | |||
| ): | |||
| if device.core_grid.y != 8: | |||
| if device.core_grid.y != 8 and is_wormhole_b0(): | |||
| pytest.skip("Needs 8x8 Grid") | |||
There was a problem hiding this comment.
this comment doesn't make sense anymore
| @@ -983,6 +983,8 @@ conv_op_l1_usage conv2d::calculate_L1_usage( | |||
| (per_core_out_matrix_height_ntiles + act_block_h_ntiles - 1) / act_block_h_ntiles; | |||
| uint32_t out_block_h_ntiles_padded = num_blocks_act_h_per_core * act_block_h_ntiles; | |||
|
|
|||
| uint32_t alignment_bytes = arch == tt::ARCH::BLACKHOLE ? 64 : 32; | |||
There was a problem hiding this comment.
Get l1 aligment from HAL
skrsticTT
force-pushed
the
skrstic/enable-bh-tests
branch
from
c5b8abc to
1733874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#17221
#17216
Problem description
Enable conv2d blackhole tests - to begin with, remove the skips in
tests/ttnn/unit_tests/operations/test_new_conv2d.pyand provide a report about state of tests. Fix minor bugs described in issues.What's changed
@skip_for_blackhole()for tests that already run on wormhole_b0calculate_L1_usagefunctionState of blackhole tests after this changes
repro:
pytest tests/ttnn/unit_tests/operations/test_new_conv2d.pyPASSED: 2244
FAILED: 65
97% pass rate
Of the tests that fail:
47 of them fail because of PCC error
18 of them fail because of an assert
conv2d_op_width_sharded_program_factory.cpp(these problems are going to be tracked in proper issues)
Checklist