Minimalistic All Gather Async #17007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davorchap
reviewed
Jan 23, 2025
ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_optimized_all_gather_reader.cpp
Outdated
Show resolved
Hide resolved
davorchap
reviewed
Jan 23, 2025
ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_optimized_all_gather_reader.cpp
Outdated
Show resolved
Hide resolved
davorchap
reviewed
Jan 23, 2025
ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_optimized_all_gather_writer.cpp
Outdated
Show resolved
Hide resolved
davorchap
reviewed
Jan 23, 2025
ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_optimized_all_gather_writer.cpp
Outdated
Show resolved
Hide resolved
SeanNijjar
reviewed
Jan 23, 2025
ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_optimized_all_gather_writer.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_optimized_all_gather_writer.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_optimized_all_gather_writer.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_optimized_all_gather_reader.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_optimized_all_gather_reader.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/ccl/common/host/ccl_worker_builder.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_optimized_all_gather_writer.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/experimental/ccl/all_gather_async/device/all_gather_async_program.cpp
Outdated
Show resolved
Hide resolved
caixunshiren
force-pushed
the
xuncai/ccl-minimal
branch
from
7744bad to
34d5d50
Compare
SeanNijjar
requested changes
Jan 24, 2025
...ions/experimental/ccl/all_gather_async/device/kernels/interleaved_dim3_1_1_32_any_reader.cpp
Show resolved
Hide resolved
caixunshiren
force-pushed
the
xuncai/ccl-minimal
branch
2 times, most recently
from
b221c69 to
3b6bf9a
Compare
caixunshiren
force-pushed
the
xuncai/ccl-minimal
branch
2 times, most recently
from
ed6ec7c to
5772814
Compare
…upport for all gather shapes
… specialized shape and program hashing semaphore address for generic shape)
caixunshiren
force-pushed
the
xuncai/ccl-minimal
branch
from
5772814 to
d1b28c0
Compare
SeanNijjar
approved these changes
Feb 5, 2025
...tions/experimental/ccl/all_gather_async/device/all_gather_async_program_minimal_variants.cpp
Outdated
Show resolved
Hide resolved
...tions/experimental/ccl/all_gather_async/device/all_gather_async_program_minimal_variants.cpp
Outdated
Show resolved
Hide resolved
...tions/experimental/ccl/all_gather_async/device/all_gather_async_program_minimal_variants.cpp
Outdated
Show resolved
Hide resolved
...tions/experimental/ccl/all_gather_async/device/all_gather_async_program_minimal_variants.cpp
Outdated
Show resolved
Hide resolved
...ions/experimental/ccl/all_gather_async/device/kernels/interleaved_dim3_1_1_32_any_writer.cpp
Outdated
Show resolved
Hide resolved
...s/experimental/ccl/all_gather_async/device/kernels/llama_post_binary_matmul_shape_writer.cpp
Outdated
Show resolved
Hide resolved
...tions/experimental/ccl/all_gather_async/device/all_gather_async_program_minimal_variants.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimalistic All Gather Async
Description
This pr contains the minimalistic all gather on the following shapes:
In addition, it fixes the the following bugs:
Pipelines