Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arbitrary shard-grid core range set support to addrgen in command processor (ttnn/cpp/ttnn/operations/ccl/common/kernels/ccl_send_reader_two_input.cpp) #16608

Open
Tracked by #16607 ...
SeanNijjar opened this issue Jan 10, 2025 · 1 comment

Comments

@SeanNijjar
Copy link
Contributor

SeanNijjar commented Jan 10, 2025

For TG Llama integration, it's required that CCLs support arbitrary shard grid configurations.

Support for this can be added by updating both generate_multi_command_stream_kernel_rt_args to pass runtime args for the sharded addrgen and generate_multi_command_stream_kernel_ct_args for compile time args, respectively.

For all CCL's to enable this behaviour from host side, I think only these should require updates.

Required Test Cases:

  • input and output shapes
  • input and output shard specs
  • other op specific attributes (e.g. gather dim)

TODO

@SeanNijjar
Copy link
Contributor Author

FYI @johanna-rock-tt for arbitrary shard grid support. Please add test cases here (including, if possible, the padded shard cases that were newly brought up today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants