Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sharded addrgen and CCL ops to work with custom core list #16049

Closed
SeanNijjar opened this issue Dec 16, 2024 · 1 comment
Closed

Update sharded addrgen and CCL ops to work with custom core list #16049

SeanNijjar opened this issue Dec 16, 2024 · 1 comment

Comments

@SeanNijjar
Copy link
Contributor

SeanNijjar commented Dec 16, 2024

A recent feature was added to enable L1 sharded tensors to be sharded across custom core lists/ranges. This issue tracks the enablement of that feature in sharded addrgen, which is used by CCL operations.

sharded addrgens can be found here:
ttnn/cpp/ttnn/operations/ccl/shared_with_host/sharded_tensor_addr_gen.hpp

To support this feature mainly three changes will be needed:

  1. A new WorkerToNocCoordLookup will need to be implemented (e.g. ArbitraryShardCoreListCoordLookup)
  • Please add corresponding tests to tests/ttnn/unit_tests/gtests/ccl/test_ccl_tensor_slicers.cpp - should also simplify initial bringup and testing
  1. kernel side: the kernel will need to have a different codepath for instantiating this new type of coord lookup - based off of a new CT arg we pass in
  • Runtime args will accordingly need to be interpreted in a different way
    • Luckily we are already consuming RT args for coord lookup today for harvesting, so the general type of codepath already exists
  1. Update RT/CT arg generators: emit_address_generator_runtime_args for this mode (to be detected from the mem config)
@SeanNijjar
Copy link
Contributor Author

tracking moved to #16608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants