-
Notifications
You must be signed in to change notification settings - Fork 98
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove CommandQueue redirecting usages straight to HWCQ (#17219)
### Ticket #17208 ### Problem description Over time `CommandQueue` stopped playing any particular function. Today it is simply proxying calls to HWCQ via creating temporary command structures and immediately routing their execution with a big switch statement, calling into hwcq methods. This adds unreasonable complexity. After the sync with @tt-asaigal @dmakoviichuk-tt @cfjchu @omilyutin-tt , we agreed to remove this class. ### What's changed Remove CommandQueue class. Redirect all usage to HWCQ. HWCommandQueue is renamed to CommandQueue Note: * command_queue.hpp was not removed. It contains definitions of commands used by hardware_command_queue, I would prefer us to clean this up in the next PR. ### Checklist - [x] [Post commit CI](https://github.com/tenstorrent/tt-metal/actions/runs/13023052350) - [x] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/runs/13023279261) - [x] [T3k Frequent](https://github.com/tenstorrent/tt-metal/actions/runs/13021799389) -
- Loading branch information
1 parent
518fd34
commit 58f9654
Showing
26 changed files
with
303 additions
and
1,053 deletions.
There are no files selected for viewing
4 changes: 2 additions & 2 deletions
4
...rce/tt-metalium/tt_metal/apis/host_apis/command_queue/EnqueueWriteSubBuffer.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
EnqueueWriteSubBuffer | ||
===================== | ||
|
||
.. doxygenfunction:: tt::tt_metal::v0::EnqueueWriteSubBuffer(CommandQueue& cq, std::variant<std::reference_wrapper<Buffer>, std::shared_ptr<Buffer> > buffer, HostDataType src, const BufferRegion& region, bool blocking) | ||
.. doxygenfunction:: tt::tt_metal::v0::EnqueueWriteSubBuffer(CommandQueue& cq, std::variant<std::reference_wrapper<Buffer>, std::shared_ptr<Buffer> > buffer, std::vector<DType>& src, const BufferRegion& region, bool blocking) | ||
.. doxygenfunction:: tt::tt_metal::v0::EnqueueWriteSubBuffer(CommandQueue& cq, const std::variant<std::reference_wrapper<Buffer>, std::shared_ptr<Buffer> >& buffer, HostDataType src, const BufferRegion& region, bool blocking) | ||
.. doxygenfunction:: tt::tt_metal::v0::EnqueueWriteSubBuffer(CommandQueue& cq, const std::variant<std::reference_wrapper<Buffer>, std::shared_ptr<Buffer> >& buffer, std::vector<DType>& src, const BufferRegion& region, bool blocking) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.