Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13548: Remove default argument for DstSync #42

Merged
merged 1 commit into from
Oct 13, 2024
Merged

#13548: Remove default argument for DstSync #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llk_lib/llk_math_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ inline void _llk_math_wait_for_dest_available_() {
#endif
}

template <DstSync Dst = SyncFull, bool is_fp32_dest_acc_en = false>
template <DstSync Dst, bool is_fp32_dest_acc_en = false>
inline void _llk_math_dest_section_done_() {
#ifdef PERF_DUMP
if constexpr(MATH_PACK_DECOUPLE) {
Expand Down
2 changes: 1 addition & 1 deletion llk_lib/llk_math_eltwise_binary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ inline void eltwise_binary_reuse_dest_as_src() {
template <
EltwiseBinaryType eltwise_binary_type,
BroadcastType src_b_bcast_type,
DstSync Dst = DstSync::SyncFull,
DstSync Dst,
int NUM_FIDELITY_PHASES = 0,
EltwiseBinaryReuseDestType binary_reuse_dest = EltwiseBinaryReuseDestType::NONE,
bool is_fp32_dest_acc_en = false>
Expand Down
2 changes: 1 addition & 1 deletion llk_lib/llk_math_eltwise_binary_sfpu.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ inline void eltwise_binary_sfpu_configure_addrmod(){
}
inline void eltwise_binary_sfpu_configure_mop();

template <DstSync Dst = DstSync::SyncFull>
template <DstSync Dst>
inline void _llk_math_eltwise_binary_sfpu_start_(const uint dst_index) {
if constexpr ((Dst == DstSync::SyncTile16) || (Dst == DstSync::SyncTile2)) {
math::set_dst_write_addr<DstTileLayout::Default, DstTileShape::Tile32x32>(math_sync_tile_dst_index);
Expand Down
2 changes: 1 addition & 1 deletion llk_lib/llk_math_eltwise_unary_datacopy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ using namespace ckernel;
// local function declarations
inline void eltwise_unary_configure_addrmod();

template <DataCopyType type, BroadcastType src_b_bcast_type = BroadcastType::NONE, DstSync Dst = DstSync::SyncFull, bool is_fp32_dest_acc_en = false, bool unpack_to_dest = false>
template <DataCopyType type, DstSync Dst, BroadcastType src_b_bcast_type = BroadcastType::NONE, bool is_fp32_dest_acc_en = false, bool unpack_to_dest = false>
inline void _llk_math_eltwise_unary_datacopy_(const std::uint32_t dst_index, const std::uint32_t src_format, const std::uint32_t dst_format) {

if (unpack_to_dest && is_32bit_input(src_format, dst_format)) {
Expand Down
40 changes: 20 additions & 20 deletions llk_lib/llk_math_eltwise_unary_sfpi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ inline void eltwise_unary_sfpi_configure_addrmod(){
}
inline void eltwise_unary_sfpi_configure_mop();

template <SfpiTestType sfpu_op, DstSync Dst = DstSync::SyncFull>
template <SfpiTestType sfpu_op, DstSync Dst>
inline void llk_math_eltwise_unary_sfpi(
uint dst_index,
uint param0 = 0,
Expand Down Expand Up @@ -63,97 +63,97 @@ inline void llk_math_eltwise_unary_sfpi_init(

// New LLK SFPU APIs

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test1(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test1, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test2(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test2, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test3(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test3, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test4(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test4, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test5(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test5, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test6(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test6, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test7(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test7, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test8(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test8, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test9(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test9, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test10(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test10, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test11(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test11, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test12(uint dst_index, uint param0) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test12, dst_sync>(dst_index, param0);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test13(uint dst_index, uint param0) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test13, dst_sync>(dst_index, param0);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test14(uint dst_index, uint param0) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test14, dst_sync>(dst_index, param0);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test15(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test15, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test16(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test16, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test17(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test17, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test18(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test18, dst_sync>(dst_index);
}

template <DstSync dst_sync = DstSync::SyncFull>
template <DstSync dst_sync>
inline void llk_math_eltwise_unary_sfpi_test19(uint dst_index) {
llk_math_eltwise_unary_sfpi<SfpiTestType::test19, dst_sync>(dst_index);
}
2 changes: 1 addition & 1 deletion llk_lib/llk_math_eltwise_unary_sfpu.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ inline void eltwise_unary_sfpu_configure_addrmod(){
}
inline void eltwise_unary_sfpu_configure_mop();

template <DstSync Dst = DstSync::SyncFull>
template <DstSync Dst>
inline void _llk_math_eltwise_unary_sfpu_start_(const uint dst_index) {
if constexpr ((Dst == DstSync::SyncTile16) || (Dst == DstSync::SyncTile2)) {
math::set_dst_write_addr<DstTileLayout::Default, DstTileShape::Tile32x32>(math_sync_tile_dst_index);
Expand Down
2 changes: 1 addition & 1 deletion llk_lib/llk_pack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ inline void _llk_pack_init_(const std::uint32_t pack_dst_format, const std::uint
);
}

template <DstSync Dst = SyncFull, bool untilize = false, bool is_fp32_dest_acc_en = false>
template <DstSync Dst, bool untilize = false, bool is_fp32_dest_acc_en = false>
inline void _llk_pack_(const std::uint32_t tile_index, const std::uint32_t address) {

constexpr uint32_t DEST_NUM_TILES_SHIFT = is_fp32_dest_acc_en ? (1) : (0);
Expand Down
Loading