#9370: Workaround for the issue, replace WRCFG with RMWCIB instruction for reduce_revert_delta #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns in reduce_revert_delta function
amahmudTT
requested review from
ttmtrajkovic,
rdjogoTT and
rtawfik01
and removed request for
rtawfik01
rtawfik01
reviewed
Sep 18, 2024
rtawfik01
approved these changes
Sep 18, 2024
|
All post commit tests passed with this change applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9370
tenstorrent/tt-metal#9370
Problem description
The Unpacker uses stale value for address for SrcB even though it is written. It seems to be colliding with WRCFG instructions used in the reduce_revert_delta function. We kept the timing the same and replaced WRCFG instructions with RMWCIB instructions to do the bare minimum and the problem goes away.
What's changed
The workaround uses RMWCIB instructions in the reduce_revert_delta function for wh_b0. It does not have the same timing and consumes more cycles but is functionally the same as what was in the original function.