Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tt-torch model test parser #8

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

nsmithtt
Copy link
Contributor

@nsmithtt nsmithtt commented Dec 3, 2024

No description provided.

@nsmithtt
Copy link
Contributor Author

nsmithtt commented Dec 3, 2024

Copy link
Contributor

@vmilosevic vmilosevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include test for TTTorchModelTestsParser? Simple test is enough, process one file and assert that number of discovered tests is correct.

Copy link
Contributor

@vmilosevic vmilosevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@warthog9
Copy link
Member

warthog9 commented Dec 4, 2024

No issues from my side

@nsmithtt nsmithtt requested a review from vmilosevic December 4, 2024 03:09
@vmilosevic
Copy link
Contributor

@nsmithtt The error you see in the workflow is because you are making a PR from the fork, and it doesn't have permission to add comments to PR to show the report.

We can ignore this, easiest way to get around this is by adding "continue-on-error: true" to "Show reports" step

File .github/workflows/test_collect_data_action.yml Line 37 add
continue-on-error: true

@vmilosevic vmilosevic merged commit 1285bee into tenstorrent:main Dec 4, 2024
2 checks passed
@nsmithtt nsmithtt deleted the nsmith/tt-torch2 branch December 4, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants