Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark field mapping #15

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

vmilosevic
Copy link
Contributor

Updated according to comments:

I briefly looked at the data and I'd like to give some suggestions to improve data quality in the future:
config_params is Optional[dict], you can leave it as null, instead of putting an empty dict
Even though input_sequence_length / output_sequence_length / image_dimension are optional fields, I strongly recommend you to fill in some of them depending on the model type you're benchmarking (LLM vs. CV models). This will benefit any downstream analysis utilizing benchmark data that could happen in the future.
run_type is a required attribute, please fill in something meaningful instead of putting an empty string to bypass the Pydantic model checks. Same suggestion for step_name inside the measurements.

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
src
   benchmark.py40392%53–55
   cicd.py64395%85–87
   generate_data.py32778%48–66
   pydantic_models.py970100% 
   test_parser.py251156%31–36, 40–45
   utils.py100496%44, 123, 176–179
src/parsers
   junit_xml_utils.py47687%85–89, 93–97
   parser.py10280%23, 33
   python_pytest_parser.py69691%19, 52, 55, 81, 131–132
   python_unittest_parser.py61198%30
   tt_torch_model_tests_parser.py620100% 
TOTAL6074393% 

Tests Skipped Failures Errors Time
6 0 💤 0 ❌ 0 🔥 0.517s ⏱️

@vmilosevic vmilosevic merged commit 37d6d6e into main Dec 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant