-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaces fmt and json header files and uses cmake to download them #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I see that you update tt-mlir. Is there specific reason for doing so?
There wasn't. I can revert this |
This comment was marked as resolved.
This comment was marked as resolved.
bc6c057
to
5f22c36
Compare
@nvukobratTT The tt-tvm repo had circular dependencies with forge so I created a branch in the tt-tvm repo and updated their Buda cmake file to have the right paths for including directories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner solution! Thanks for pushing this further!
Make sure to open PR for TVM and getting approval before merging this change :)) |
We should probably keep one branch on tt-tvm to use as integration branch for tt-forge-fe, so that we don't break tvm for pybuda. @nvukobratTT thoughts? |
I agree. @ttdloke let's create |
@nvukobratTT done, here's the branch https://github.com/tenstorrent/tt-tvm/tree/forge_track |
This is for @staylorTT so we can open source this repo. Removed old header files for fmt and json and now download them using their latest stable releases. Commented out all the errors that popped up because of the update to those libraries