Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaces fmt and json header files and uses cmake to download them #97

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ttdloke
Copy link
Contributor

@ttdloke ttdloke commented Aug 15, 2024

This is for @staylorTT so we can open source this repo. Removed old header files for fmt and json and now download them using their latest stable releases. Commented out all the errors that popped up because of the update to those libraries

Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I see that you update tt-mlir. Is there specific reason for doing so?

.gitignore Outdated Show resolved Hide resolved
pybuda/csrc/graph_lib/utils.cpp Outdated Show resolved Hide resolved
pybuda/csrc/pybuda_bindings.cpp Outdated Show resolved Hide resolved
pybuda/csrc/shared_utils/sparse_matmul_utils.cpp Outdated Show resolved Hide resolved
third_party/CMakeLists.txt Outdated Show resolved Hide resolved
@nvukobratTT nvukobratTT requested a review from pilkicTT August 16, 2024 07:25
@ttdloke
Copy link
Contributor Author

ttdloke commented Aug 16, 2024

Also, I see that you update tt-mlir. Is there specific reason for doing so?

There wasn't. I can revert this

@ttdloke
Copy link
Contributor Author

ttdloke commented Aug 16, 2024

#131

@pilkicTT

This comment was marked as resolved.

@ttdloke ttdloke force-pushed the dloke/cmake branch 3 times, most recently from bc6c057 to 5f22c36 Compare August 23, 2024 16:21
@ttdloke
Copy link
Contributor Author

ttdloke commented Aug 23, 2024

@nvukobratTT The tt-tvm repo had circular dependencies with forge so I created a branch in the tt-tvm repo and updated their Buda cmake file to have the right paths for including directories.

Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner solution! Thanks for pushing this further!

pybuda/csrc/runtime/runtime.cpp Outdated Show resolved Hide resolved
@nvukobratTT
Copy link
Contributor

@nvukobratTT The tt-tvm repo had circular dependencies with forge so I created a branch in the tt-tvm repo and updated their Buda cmake file to have the right paths for including directories.

Make sure to open PR for TVM and getting approval before merging this change :))

@pilkicTT
Copy link
Contributor

@nvukobratTT The tt-tvm repo had circular dependencies with forge so I created a branch in the tt-tvm repo and updated their Buda cmake file to have the right paths for including directories.

Make sure to open PR for TVM and getting approval before merging this change :))

We should probably keep one branch on tt-tvm to use as integration branch for tt-forge-fe, so that we don't break tvm for pybuda. @nvukobratTT thoughts?

@nvukobratTT
Copy link
Contributor

@nvukobratTT The tt-tvm repo had circular dependencies with forge so I created a branch in the tt-tvm repo and updated their Buda cmake file to have the right paths for including directories.

Make sure to open PR for TVM and getting approval before merging this change :))

We should probably keep one branch on tt-tvm to use as integration branch for tt-forge-fe, so that we don't break tvm for pybuda. @nvukobratTT thoughts?

I agree. @ttdloke let's create forge_track branch, and feel free to mege TVM changes there and reference here. Once you do that, let's merge these changes into FFE repo as well :))

@ttdloke
Copy link
Contributor Author

ttdloke commented Aug 26, 2024

@nvukobratTT The tt-tvm repo had circular dependencies with forge so I created a branch in the tt-tvm repo and updated their Buda cmake file to have the right paths for including directories.

Make sure to open PR for TVM and getting approval before merging this change :))

We should probably keep one branch on tt-tvm to use as integration branch for tt-forge-fe, so that we don't break tvm for pybuda. @nvukobratTT thoughts?

I agree. @ttdloke let's create forge_track branch, and feel free to mege TVM changes there and reference here. Once you do that, let's merge these changes into FFE repo as well :))

@nvukobratTT done, here's the branch https://github.com/tenstorrent/tt-tvm/tree/forge_track

@ttdloke ttdloke merged commit cb7356d into main Aug 26, 2024
2 checks passed
@nvukobratTT nvukobratTT deleted the dloke/cmake branch September 9, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants