Updating Metal version and removing data type overrides from MNIST model #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdjordjevicTT
requested review from
pilkicTT,
nvukobratTT,
vladimirjovanovicTT,
nsmithtt and
dgolubovicTT
nvukobratTT
approved these changes
Aug 9, 2024
sdjordjevicTT
force-pushed
the
sdjordjevic/update_tt_mlir_and_metal_version
branch
from
8b7a37b to
f24da15
Compare
sdjordjevicTT
force-pushed
the
sdjordjevic/update_tt_mlir_and_metal_version
branch
from
f24da15 to
d982513
Compare
pilkicTT
approved these changes
Aug 9, 2024
sdjordjevicTT
deleted the
sdjordjevic/update_tt_mlir_and_metal_version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to make workarounds for the MNIST model because the current version of Metal did not support the float32 data type. TT-MLIR has updated the version of Metal to support the float32 data types, so we are updating the reference to the TT-MLIR to include that Metal version update. Along the way, the bfloat16 overrides from the MNIST model will be removed to verify that everything is working as expected.
Solves: https://github.com/tenstorrent/tt-forge/issues/51