Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding workflow files for checking for Copyright headers. #38

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

staylorTT
Copy link
Contributor

Adding the spdx / copyright workflow changes based off the ones we have in tt-mlir. Is there a way to check if these run as expected?

@sdjordjevicTT
Copy link
Contributor

It seems that the spdx check failed in this pipeline. Can you please check whether we need spdx headers in these files:
NO SPDX ./pybuda/pybuda/fx/init.py
NO SPDX ./pybuda/test/mlir/mnist/init.py
NO SPDX ./pybuda/test/fx/init.py
NO SPDX ./pybuda/test/operators/tm/fuse/init.py
NO SPDX ./pybuda/test/tvm/cnn/pytorch/videopose/model.py
NO SPDX ./third_party/fmt/fmt/args.h
NO SPDX ./third_party/fmt/fmt/ranges.h
NO SPDX ./third_party/fmt/fmt/xchar.h
NO SPDX ./third_party/fmt/fmt/os.h
NO SPDX ./third_party/fmt/fmt/color.h
NO SPDX ./third_party/fmt/fmt/core.h
NO SPDX ./third_party/fmt/fmt/format-inl.h
NO SPDX ./third_party/fmt/fmt/ostream.h
NO SPDX ./third_party/fmt/fmt/chrono.h
NO SPDX ./third_party/fmt/fmt/printf.h
NO SPDX ./third_party/fmt/fmt/locale.h
NO SPDX ./third_party/fmt/fmt/format.h
NO SPDX ./third_party/fmt/fmt/compile.h
NO SPDX ./third_party/json/json_fwd.hpp
NO SPDX ./third_party/json/json.hpp
NO SPDX ./third_party/json/pybind11_json.hpp

@staylorTT
Copy link
Contributor Author

For Third Party files see #40

for the empty init files I have submitted a PR in the enarx/ repo: enarx/spdx#22

@staylorTT
Copy link
Contributor Author

Empty files will now be ignored by the checker.

@staylorTT staylorTT self-assigned this Aug 13, 2024
@staylorTT staylorTT added documentation Improvements or additions to documentation blocked labels Aug 13, 2024
@staylorTT
Copy link
Contributor Author

@nvukobratTT PTAL if you can.

Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for pushing this further!

@vmilosevic can you confirm if config files are optimal? Are there some improvements you would suggest? If not, please approve this PR as well.

@staylorTT
Copy link
Contributor Author

@vmilosevic Can you PTAL at this from a workflow POV to make sure it's compatible with what you had in mind.

Copy link
Collaborator

@vmilosevic vmilosevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@staylorTT staylorTT merged commit f4464bf into main Aug 27, 2024
3 checks passed
@staylorTT staylorTT deleted the staylor/spdx branch September 4, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix SPDX license headers for repo and include a check to prevent missing headers.
4 participants