Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staylor/cleanup Removing internal references from Forge #35

Merged
merged 4 commits into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pybuda/test/fx/test_basics.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class NoInputModel(torch.nn.Module):
def forward(self):
return torch.tensor([1])

@pytest.mark.skip(reason="https://yyz-gitlab.local.tenstorrent.com/tenstorrent/pybuda/-/issues/2475")
def test_no_input_model():
# Test the case where the model has no inputs
generic_model_test(NoInputModel(), num_inputs=0)
Expand Down Expand Up @@ -61,7 +60,6 @@ def test_print():
tensor = torch.rand(32, 32).to('tt')
print(tensor)

@pytest.mark.skip(reason="https://yyz-gitlab.local.tenstorrent.com/tenstorrent/pybuda/-/issues/2438")
def test_longint():
original_data = torch.randint(0, 10, (1, 8))
tensor = original_data.to('tt').to(dtype=torch.int).to('cpu')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def test_yolov5_320x320(test_device, size):


def generate_model_yoloV5I640_imgcls_torchhub_pytorch(test_device, variant, size):
# Add required env vars as per: https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/46
# env vars needed to support 640x640 yolov5 working
compiler_cfg = _get_global_compiler_config()
compiler_cfg.balancer_policy = "Ribbon"
compiler_cfg.enable_auto_fusing = False
Expand Down Expand Up @@ -233,7 +233,7 @@ def generate_model_yoloV5I480_imgcls_torchhub_pytorch(test_device, variant, size
os.environ["TT_BACKEND_OVERLAY_MAX_EXTRA_BLOB_SIZE"] = f"{16*1024}"

elif test_device.arch == BackendDevice.Wormhole_B0:
# Add required env vars as per: https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/46
# env vars needed to support 640x640 yolov5 working
compiler_cfg.default_df_override = DataFormat.Float16_b

os.environ["PYBUDA_RIBBON2"] = "1"
Expand Down Expand Up @@ -300,7 +300,7 @@ def test_yolov5_480x480(test_device, size):

@pytest.mark.skip(reason="Not supported")
def test_yolov5_1280x1280(test_device):
# Add required env vars as per: https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/46
# env vars needed to support 640x640 yolov5 working
os.environ["PYBUDA_PAD_SPARSE_MM"] = "{13:16}"
os.environ["PYBUDA_INSERT_SLICE_FOR_CONCAT"] = "1"

Expand Down
1 change: 0 additions & 1 deletion pybuda/test/tvm/cnn/pytorch/tests_A/test_googlenet.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ def test_googlenet_torchvision(test_kind, test_device):
): # Always run with recompute in post-commit CI. Nightly tests both
pytest.skip()

# Adding required environment variables as per https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/43
import os
# This will allow the test to pass but we should use conv padding to fix the issue instead
# os.environ["PYBUDA_EXTRA_L1_MARGIN"] = "30000"
Expand Down
1 change: 0 additions & 1 deletion pybuda/test/tvm/cnn/pytorch/tests_B/test_mobilenet_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ def test_mobilenetv2_deeplab(test_kind, test_device):
if test_kind.is_training():
pytest.skip() # Backward is currently unsupported

# SET CONV PADDING ENVIRONMENT VARIABLE: https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/36
import os
os.environ["PYBUDA_PAD_SPARSE_MM"] = "{25:26}"

Expand Down
4 changes: 0 additions & 4 deletions pybuda/test/tvm/cnn/pytorch/tests_C/test_densenet.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ def test_densenet_121(test_kind, test_device):
compiler_cfg = _get_global_compiler_config()
compiler_cfg.balancer_policy = "CNN"

# Add required env vars as per https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/48
import os
os.environ["PYBUDA_DISABLE_CONSTANT_FOLDING"] = "1"

Expand Down Expand Up @@ -56,7 +55,6 @@ def test_densenet_169(test_kind, test_device):
compiler_cfg = _get_global_compiler_config()
compiler_cfg.balancer_policy = "CNN"

# Add required env vars as per https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/48
import os
os.environ["PYBUDA_DISABLE_CONSTANT_FOLDING"] = "1"
os.environ["PYBUDA_GRAPHSOLVER_SELF_CUT_TYPE"] = "ConsumerOperandDataEdgesFirst"
Expand Down Expand Up @@ -89,7 +87,6 @@ def test_densenet_201(test_kind, test_device):
compiler_cfg = _get_global_compiler_config()
compiler_cfg.balancer_policy = "CNN"

# Add required env vars as per https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/48
import os
os.environ["PYBUDA_DISABLE_CONSTANT_FOLDING"] = "1"
os.environ["PYBUDA_GRAPHSOLVER_SELF_CUT_TYPE"] = "ConsumerOperandDataEdgesFirst"
Expand Down Expand Up @@ -122,7 +119,6 @@ def test_densenet_161(test_kind, test_device):
compiler_cfg = _get_global_compiler_config()
compiler_cfg.balancer_policy = "CNN"

# Add required env vars as per https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/48
import os
os.environ["PYBUDA_DISABLE_CONSTANT_FOLDING"] = "1"
os.environ["PYBUDA_GRAPHSOLVER_SELF_CUT_TYPE"] = "ConsumerOperandDataEdgesFirst"
Expand Down
3 changes: 0 additions & 3 deletions pybuda/test/tvm/cnn/pytorch/tests_C/test_yolov5.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ def test_yolov5_480x480(test_kind, test_device):
if test_kind.is_training():
pytest.skip() # Backward is currently unsupported

# Add required env vars as per: https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/46
import os
os.environ["PYBUDA_PAD_SPARSE_MM"] = "{13:16}"
os.environ["PYBUDA_INSERT_SLICE_FOR_CONCAT"] = "1"
Expand Down Expand Up @@ -123,7 +122,6 @@ def test_yolov5m_640x640(test_kind, test_device):
if test_kind.is_training():
pytest.skip() # Backward is currently unsupported

# Add required env vars as per: https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/46
import os
os.environ["PYBUDA_PAD_SPARSE_MM"] = "{13:16, 3:4}"
os.environ["PYBUDA_INSERT_SLICE_FOR_CONCAT"] = "1"
Expand Down Expand Up @@ -162,7 +160,6 @@ def test_yolov5_1280x1280(test_kind, test_device):
if test_kind.is_training():
pytest.skip() # Backward is currently unsupported

# Add required env vars as per: https://yyz-gitlab.local.tenstorrent.com/tenstorrent/model-demos/-/issues/46
import os
os.environ["PYBUDA_PAD_SPARSE_MM"] = "{13:16}"
os.environ["PYBUDA_INSERT_SLICE_FOR_CONCAT"] = "1"
Expand Down
3 changes: 2 additions & 1 deletion scripts/compare_perf.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ def main():
build_ids = args.build_ids

# correct the build ids prefix
# TODO: Refactor the code to work on whatever new performance comparision we use in the future.
prefix = "gitlab-pipeline-"
build_ids = [(x if x.startswith(prefix) else prefix + str(x)) for x in build_ids]

Expand All @@ -106,7 +107,7 @@ def main():
if __name__ == "__main__":
main()


# TODO: Refactor the code to work on whatever new performance comparision we use in the future.
def test_compare_perf():
df = compare_perf(["gitlab-pipeline-479274", "gitlab-pipeline-479323"])
print_diff(df)
139 changes: 0 additions & 139 deletions scripts/gitlab_single_job_history.py

This file was deleted.

Loading