[Minor] Downgrading mypy from latest (1.11) to 1.10
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmithtt
approved these changes
Jul 31, 2024
(cherry picked from commit d8cb16db58c63d101bda5137b7a83ca6954d761f)
(cherry picked from commit 116dd3b147fd6f31968febc2d24c4c92c0b2a533)
(cherry picked from commit 48e64b159e17114ec083102170f39f58a524b9e0)
(cherry picked from commit 179d7adc3e822056f0a0cc242356963b0cd3ce1c)
…_models and nightly test and configuration file (cherry picked from commit 26fb354ffb75f37e8394f79ff2566e91287d14a5)
(cherry picked from commit 88b29efb09cdf658b9a05ce977f99285bd242205)
(cherry picked from commit 1283b4bd3d5e7ed53f75d20b3b165bafe004beb6)
Latest `mypy` depends on `typing-extension` >= 4.6 which conflicts with tensorflow which requires < 4.6. Downgrading `1.10` solves this issue. Tested: * Builds tt-forge OK * Run simple test OK * Run make_stups OK - no conflicts and no diff in generated stubs
mtopalovicTT
force-pushed
the
milant/downgrade_mypy_version
branch
from
18b16b0 to
a782031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest
mypydepends ontyping-extension>= 4.6 which conflicts withtensorflow2.13 version which requires < 4.6. Downgradingmypyto 1.10 solves this issue.Tested:
make_stubsOK - no conflicts and no diff in generated stubs