Improve lowering logic and lower few more ops #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdjordjevicTT
requested review from
nvukobratTT,
nsmithtt,
pilkicTT and
dgolubovicTT
sdjordjevicTT
force-pushed
the
sdjordjevic/improve_lowering_logic
branch
2 times, most recently
from
ec1751e to
693975e
Compare
sdjordjevicTT
changed the title
pilkicTT
reviewed
Jul 29, 2024
sdjordjevicTT
force-pushed
the
sdjordjevic/improve_lowering_logic
branch
from
693975e to
d28b081
Compare
pilkicTT
reviewed
Jul 29, 2024
| llvm::SmallVector<mlir::Value> output_vector; | ||
| output_vector.push_back(emit_mlir_empty_tensor(graph, op_node)); | ||
| mlir::ValueRange outputs = mlir::ValueRange(output_vector); | ||
| auto op = builder_.create<TTIROp>( |
There was a problem hiding this comment.
This is the only part of this function which depends on the template argument. Why not extract this into a function template instead?
There was a problem hiding this comment.
Take a look at few lines above:
::llvm::ArrayRef<::llvm::StringRef> operation_attributes = TTIROp::getAttributeNames();
We are getting specific operation attributes to decide which attributes to build...
There was a problem hiding this comment.
I see... sorry, missed that one...
pilkicTT
approved these changes
Jul 29, 2024
sdjordjevicTT
force-pushed
the
sdjordjevic/improve_lowering_logic
branch
from
d28b081 to
3a631f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these code changes, I managed to simplify the lowering logic. The lowering function is now a template that can be registered for all new ops. Additionally, lowering the following ops:
Solves: