bump tt-mlir version and workaround issue on CI #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason on CI, the `TT_RUNTIME_ENABLE_TTNN` flag ends up as OFF. Setting the flag explicitly in `build_mlir.sh` script. Bumping the tt-mlir version as well, to unblock work on multiple milestones.
pilkicTT
requested review from
nvukobratTT,
sdjordjevicTT,
vmilosevic and
vladimirjovanovicTT
nvukobratTT
approved these changes
Aug 28, 2024
sdjordjevicTT
approved these changes
Aug 28, 2024
Merged! |
pilkicTT
added a commit
that referenced
this pull request
Aug 28, 2024
We've hit build issues when bumping tt-mlir version and to resolve those #190 was merged. This is a follow up change with a cleaner fix. Github runner will reuse the same folder for repo checkout between jobs. The checkout action from github cleans leftover files, but not for git submodules within a repo. This creates a problem, since it can happen that cmake doesn't regenerate build files, but incorrectly, reuse ones that were left over. This change enforces cleanup of git submodules, resulting in correct, but slower builds.
pilkicTT
added a commit
that referenced
this pull request
Aug 28, 2024
We've hit build issues when bumping tt-mlir version and to resolve those #190 was merged. This is a follow up change with a cleaner fix. Github runner will reuse the same folder for repo checkout between jobs. The checkout action from github cleans leftover files, but not for git submodules within a repo. This creates a problem, since it can happen that cmake doesn't regenerate build files, but incorrectly, reuse ones that were left over. This change enforces cleanup of git submodules, resulting in correct, but slower builds. Also, the build command is rewritten to be more explicit.
pilkicTT
added a commit
that referenced
this pull request
Aug 29, 2024
We've hit build issues when bumping tt-mlir version and to resolve those #190 was merged. This is a follow up change with a cleaner fix. Github runner will reuse the same folder for repo checkout between jobs. The checkout action from github cleans leftover files, but not for git submodules within a repo. This creates a problem, since it can happen that cmake doesn't regenerate build files, but incorrectly, reuse ones that were left over. This change enforces cleanup of git submodules, resulting in correct, but slower builds. Also, the build command is rewritten to be more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason on CI, the
TT_RUNTIME_ENABLE_TTNNflag ends up as OFF. Setting the flag explicitly inbuild_mlir.shscript.Bumping the tt-mlir version as well, to unblock work on multiple milestones.