-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs Homepage #23
base: main
Are you sure you want to change the base?
Docs Homepage #23
Conversation
@mwvd I have deployed this version onto staging here https://tenstorrent-docs-test.github.io/ One of the new changes the team requested is a prominent Getting Started section on the new homepage. The new getting started section is here - https://tenstorrent-docs-test.github.io/quickstart.html Also, we decided to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 👍
@@ -1,6 +1,256 @@ | |||
Tenstorrent | |||
============================== | |||
|
|||
.. raw:: html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use :include:
tag here and have the HTML inside of home.html
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes- much better idea- I'll do this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't figure this out with :include:
, but was able to move the HTML into /core/_templates/home.html
and then include it here with:
.. raw:: html
:file: _templates/home.html
Hides sphinx generated homepage header (https://docs.tenstorrent.com/) | ||
*/ | ||
|
||
#tenstorrent > h1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I not remove it via deleting the first two lines of index.rst
Tenstorrent
==============================
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimitri-tenstorrent seems like the staging build is missing everything below the "All Documentation" header: Is this just because of config handling orchestration for staging? Or would this be the same in the production environment also |
I'll talk to Keith about this tomorrow and aim for EOW in another PR
✅ |
Ah, the table of contents was hidden in the last version, but I can re-add it to this one. |
…hub.io into feature/homepage
Docs homepage updates
This PR adds a refreshed homepage to the documentation site
Changes
core/index.rst
sphinx
generated page header forcore/index.rst
shared/_static/home.css
core/_static/assets/home
Notes
Reusable sections in raw generated HTML here could possibly also be automated with Javascript:
Note
In this example I moved image assets from
core/_static/assets/home
intocore/_static/home/assets
(see
core/_static/home/data.json
below)core/index.rst
:core/_static/home/data.json
:This approach is probably easier to maintain long-term, but I don't really like the idea of introducing client-side rendering to a docs site, especially when it's async (
sections
could be inline JS and we could drop theasync
, but then it's not quickly openable from a code editor). I'm open to other thoughts here.Screenshots