Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ubuntu22.04 as base image; Bump torch and lighting #15

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Set ubuntu22.04 as base image; Bump torch and lighting #15

merged 2 commits into from
Feb 14, 2024

Conversation

bfreskura
Copy link
Contributor

@bfreskura bfreskura commented Feb 10, 2024 •
edited
Loading

Torch actually comes with cuda and cudnn included so we don't need it in the base image.

Reduces image size by ~4GB

https://discuss.pytorch.org/t/does-pytorch-use-the-cudatoolkit-in-docker-or-the-system/140303

  • Switch from pre-commit github package to a local runtime in actions
  • Bump torch and lightning

@bfreskura bfreskura requested a review from jere357 February 10, 2024 15:45
jere357
jere357 reviewed Feb 14, 2024
View reviewed changes
.github/workflows/linter.yml Outdated Show resolved Hide resolved
.github/workflows/linter.yml Show resolved Hide resolved
@bfreskura bfreskura requested a review from jere357 February 14, 2024 14:31
@jere357 jere357 merged commit ec4aac3 into master Feb 14, 2024
3 checks passed
@jere357 jere357 deleted the feature/optimizeImage branch February 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jere357 jere357 jere357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfreskura @jere357