Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mojolicious 8.0 compatibility #13

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Changes
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
This file documents the revision history for the Mojolicious::Command::deploy::heroku distribution.

0.13 2020-02-12 00:00:00
- Fix Mojolicious 8 compatibility issue (memowe)

0.12 2015-05-17 00:00:00
- Hide passwords (MattOates)
- Check that Makefile.PL compiles before deploying (briandfoy)

0.11 2014-06-27 00:00:00
- Update Mojolicious dependency version (compatibility)

0.10 2012-08-23 00:00:00
- Removed dependency of MOJO_APP env variable
- Fixed inconsistencies in Perloku file generation, with ./command
Expand Down
Binary file removed Mojolicious-Command-deploy-heroku-0.12.tar.gz
Binary file not shown.
6 changes: 4 additions & 2 deletions README.pod
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ L<Mojolicious::Command::deploy::heroku> deploys a Mojolicious app to Heroku.

*NOTE* The deploy command itself works on Windows, but the Heroku service does not reliably accept deployments from Windows. Your mileage may vary.

*NOTE* This release works with Mojolicious versions 4.50 and above. For older Mojolicious versions, please use 0.10 or before.
*NOTE* This release works with Mojolicious versions 8 and above. For older Mojolicious versions, please use 0.12 or before.

=head1 WORKFLOW

Expand Down Expand Up @@ -65,7 +65,7 @@ L<http://github.com/tempire/mojolicious-command-deploy-heroku>

=head1 VERSION

0.22
0.13

=head1 AUTHOR

Expand All @@ -77,4 +77,6 @@ MattOates

briandfoy

Mirko Westermeier

=cut
5 changes: 3 additions & 2 deletions dist.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name = Mojolicious-Command-deploy-heroku
auth = Glen Hinkle <[email protected]>
license = Perl_5
copyright_holder = Glen Hinkle
version = 0.12
version = 0.13

[@Filter]
bundle = @Basic
Expand All @@ -12,7 +12,8 @@ bundle = @Basic
File::Path = 2.08
File::Slurp = 9999.19
IPC::Cmd = 0.78
Mojolicious = 4.82
IO::Prompter = 0.004015
Mojolicious = 8.00
Mojolicious::Command::deploy = 0.01
Net::Heroku = 0.08
;IO::All = 0.44
Expand Down
8 changes: 5 additions & 3 deletions lib/Mojolicious/Command/deploy/heroku.pm
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ use IPC::Cmd 'can_run';
use Mojo::IOLoop;
use Mojo::UserAgent;
use Mojolicious::Command::generate::heroku;
use Mojolicious::Command::generate::makefile;
use Mojolicious::Command::Author::generate::makefile;
use Net::Heroku;

our $VERSION = 0.12;
our $VERSION = 0.13;

has tmpdir => sub { $ENV{MOJO_TMPDIR} || File::Spec->tmpdir };
has ua => sub { Mojo::UserAgent->new->ioloop(Mojo::IOLoop->singleton) };
Expand Down Expand Up @@ -186,7 +186,7 @@ sub create_or_get_key {
sub generate_makefile {
my $self = shift;

my $command = Mojolicious::Command::generate::makefile->new;
my $command = Mojolicious::Command::Author::generate::makefile->new;
my $file = $self->app->home->rel_file($self->makefile);

if (!file_exists($file)) {
Expand Down Expand Up @@ -463,4 +463,6 @@ MattOates

briandfoy

Mirko Westermeier

=cut