registry: add GET api/v1/trunk-project/{name}, api/v1/trunk-project/{name}/version/{version}
#519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/{name}/version/{version}`
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
sjmiller609
approved these changes
Oct 30, 2023
Comment on lines
+164
to
+168
| pub async fn trunk_projects_by_name( | ||
| &self, | ||
| trunk_project_name: &str, | ||
| ) -> Result<Vec<TrunkProjectView>> { | ||
| let records = sqlx::query!( |
There was a problem hiding this comment.
I think this would be a lot easier as a view then use JSONB WHERE, and this way I think is duplicating the json schema into multiple locations, which could be slightly tricker! but I still think this is fine
There was a problem hiding this comment.
Yea, I'm pondering on ways to remove this repetition as well :s
As a view with JSONB WHERE would we be fetching all information first and then filtering it later on?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.