accept featureFlags.EnableTektonOCIBundles to fix unknown field error

[jkandasa]

Changes

• fixes featureFlags.EnableTektonOCIBundles becomes unknown fields #8359
• EnableTektonOCIBundles removed on https://github.com/tektoncd/pipeline/pull/7789/files#diff-43c816abe932bdd16552907bcaac8c510320e205a874f5ff04dea69553e1bc7cR187, and EnableTektonOCIBundles becomes unknown field, To fix this issue. EnableTektonOCIBundles added back to the featureFlags. EnableTektonOCIBundles as bool pointer. This value never used.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind bug

[jkandasa]

/cc @vdemeester

[jkandasa]

/test check-pr-has-kind-label

[tekton-robot]

@jkandasa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-tekton-pipeline-alpha-integration-tests
• /test pull-tekton-pipeline-beta-integration-tests
• /test pull-tekton-pipeline-build-tests
• /test pull-tekton-pipeline-integration-tests
• /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

• /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jkandasa]

/kind bug

[vdemeester]

cc @afrittoli @chitrangpatel

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Fantaztig]

Whats the state of this? The bug currently blocks us from deleting old PipelineRuns..

[afrittoli]

@vdemeester @jkandasa Looking at the issue, it says that PipelineRuns cannot be deleted, so I think a good fix would be to stop trying to validate a PipelineRun on deletion, if that's what's happening.

In the issue it also shows the log:

error: pipelineruns.tekton.dev "installer-l0v75d" could not be patched:

The message there makes me wonder if the PipelineRun is being deleted or patched... perhaps kubectl attempts to patch the resource before deleting it?

[Fantaztig]

How I understood it the PipelineRuns are stuck at deletion (we have the same issue) and when trying to remove the finalizers the log message appears.
We also tried different ways of removing the finalizers but were also hit with cannot decode incoming old object: json: unknown field "EnableTektonOCIBundles"

[afrittoli]

How I understood it the PipelineRuns are stuck at deletion (we have the same issue) and when trying to remove the finalizers the log message appears. We also tried different ways of removing the finalizers but were also hit with cannot decode incoming old object: json: unknown field "EnableTektonOCIBundles"

It sounds to me like the issue is that the finaliser is trying to do more than it should really.
If we fixed that it would solve the problem not only for this specific fields but for others too.