TEP-0142: Add support for params between Step and StepActions #7332

chitrangpatel · 2023-11-03T20:17:00Z

Following the previous PR, which introduced the syntax in Steps to provide params to StepAction, this PR reconciles param usage between Steps and StepActions. This completes support for params in StepActions. This work is part of issue #7259.

Changes

We how pass objectParam replacements inside a Task since the Steps can provide params to StepActions. The params passed to StepActions could be object params and could require objectParam replacements.

For example, this is now allowed:

steps:
  - ref:
      name: step-action
  params:
    - name: object-param
       value: $(params.objectparam[*])

Therefore, we now need to allow passing of objectParams into a Task.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[WIP] Completes support for params in StepActions.

/kind feature

tekton-robot · 2023-11-03T20:26:04Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	98.2%	98.2%	0.0
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-03T20:26:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	98.2%	98.2%	0.0
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-03T20:29:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	98.2%	98.2%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.2%	98.2%	0.0
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-06T15:30:58Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	98.2%	98.2%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.2%	98.2%	0.0
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-06T15:32:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	98.2%	98.2%	0.0
pkg/apis/pipeline/v1beta1/task_validation.go	98.2%	98.2%	0.0
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

chitrangpatel · 2023-11-06T16:24:53Z

/hold /hold wait for #7334

pkg/reconciler/pipelinerun/resources/apply.go

pkg/reconciler/taskrun/resources/apply.go

chitrangpatel · 2023-11-08T02:09:55Z

/hold cancel

tekton-robot · 2023-11-08T02:16:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-08T02:20:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-08T15:23:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-08T15:24:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-08T16:02:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-08T16:03:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.5%	0.3
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

examples/v1/pipelineruns/alpha/stepaction-params.yaml

pkg/reconciler/taskrun/resources/apply.go

tekton-robot · 2023-11-08T18:17:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.4%	0.2
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-08T18:18:45Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.4%	0.2
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-08T19:01:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.3%	0.2
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-08T19:03:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.3%	0.2
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

Yongxuanzhang

Thanks! Just some minor comments/questions

pkg/reconciler/taskrun/resources/apply.go

pkg/reconciler/taskrun/resources/apply_test.go

pkg/reconciler/taskrun/resources/taskspec_test.go

pkg/reconciler/taskrun/resources/validate_params.go

tekton-robot · 2023-11-08T20:15:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Yongxuanzhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Following the previous [PR](tektoncd#7317), which introduced Params to the `StepAction` CRD, this PR integrates `param` usage between `Steps` and `StepActions`. This completes support for params in `StepActions`. This work is part of issue tektoncd#7259.

tekton-robot · 2023-11-09T01:21:55Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.3%	0.2
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

tekton-robot · 2023-11-09T01:23:55Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.3%	0.2
pkg/reconciler/taskrun/resources/validate_params.go	93.3%	97.2%	3.9

jerop

🎉

/lgtm

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 3, 2023

tekton-robot requested review from dibyom and pritidesai November 3, 2023 20:17

chitrangpatel marked this pull request as draft November 3, 2023 20:17

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023

chitrangpatel mentioned this pull request Nov 3, 2023

TEP-0142: Enable Step Reusability - Implementation #7259

Closed

20 tasks

chitrangpatel force-pushed the step-action-params branch from 7112cad to 1bb89d3 Compare November 3, 2023 20:21

chitrangpatel changed the title ~~Add support for params between Step and StepActions~~ TEP-0142: Add support for params between Step and StepActions Nov 3, 2023

chitrangpatel force-pushed the step-action-params branch from 1bb89d3 to d335ab3 Compare November 6, 2023 15:22

chitrangpatel marked this pull request as ready for review November 6, 2023 15:23

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2023

tekton-robot requested a review from jerop November 6, 2023 15:23

chitrangpatel mentioned this pull request Nov 6, 2023

TEP-0142: Add syntax for providing params to StepActions #7334

Merged

7 tasks

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2023

chitrangpatel force-pushed the step-action-params branch from d335ab3 to e9a11c3 Compare November 6, 2023 16:29

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 6, 2023

jerop reviewed Nov 6, 2023

View reviewed changes

pkg/reconciler/pipelinerun/resources/apply.go Show resolved Hide resolved

jerop reviewed Nov 6, 2023

View reviewed changes

pkg/reconciler/taskrun/resources/apply.go Show resolved Hide resolved

chitrangpatel force-pushed the step-action-params branch from e9a11c3 to b5c8be7 Compare November 8, 2023 02:09

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2023

chitrangpatel force-pushed the step-action-params branch from b5c8be7 to c6958c9 Compare November 8, 2023 15:16

chitrangpatel requested a review from jerop November 8, 2023 15:16

chitrangpatel force-pushed the step-action-params branch from c6958c9 to 45563e4 Compare November 8, 2023 15:55

Yongxuanzhang reviewed Nov 8, 2023

View reviewed changes

examples/v1/pipelineruns/alpha/stepaction-params.yaml Show resolved Hide resolved

pkg/reconciler/taskrun/resources/apply.go Outdated Show resolved Hide resolved

pkg/reconciler/taskrun/resources/apply.go Outdated Show resolved Hide resolved

Yongxuanzhang reviewed Nov 8, 2023

View reviewed changes

pkg/reconciler/taskrun/resources/apply.go Outdated Show resolved Hide resolved

pkg/reconciler/taskrun/resources/apply.go Outdated Show resolved Hide resolved

chitrangpatel force-pushed the step-action-params branch from 45563e4 to 916596c Compare November 8, 2023 18:08

chitrangpatel requested a review from Yongxuanzhang November 8, 2023 18:09

chitrangpatel force-pushed the step-action-params branch from 916596c to 5195129 Compare November 8, 2023 18:54

Yongxuanzhang approved these changes Nov 8, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023

chitrangpatel force-pushed the step-action-params branch from 5195129 to b0b1c0c Compare November 9, 2023 01:15

jerop reviewed Nov 9, 2023

View reviewed changes

tekton-robot assigned jerop Nov 9, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023

tekton-robot merged commit c2098de into tektoncd:main Nov 9, 2023
2 checks passed

jerop added this to the Pipelines v0.54 milestone Nov 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEP-0142: Add support for params between Step and StepActions #7332

TEP-0142: Add support for params between Step and StepActions #7332

chitrangpatel commented Nov 3, 2023 •

edited

Loading

tekton-robot commented Nov 3, 2023

tekton-robot commented Nov 3, 2023

tekton-robot commented Nov 3, 2023

tekton-robot commented Nov 6, 2023

tekton-robot commented Nov 6, 2023

chitrangpatel commented Nov 6, 2023

chitrangpatel commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

Yongxuanzhang left a comment

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 9, 2023

tekton-robot commented Nov 9, 2023

jerop left a comment

TEP-0142: Add support for params between Step and StepActions #7332

TEP-0142: Add support for params between Step and StepActions #7332

Conversation

chitrangpatel commented Nov 3, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Nov 3, 2023

tekton-robot commented Nov 3, 2023

tekton-robot commented Nov 3, 2023

tekton-robot commented Nov 6, 2023

tekton-robot commented Nov 6, 2023

chitrangpatel commented Nov 6, 2023

chitrangpatel commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 8, 2023

Yongxuanzhang left a comment

Choose a reason for hiding this comment

tekton-robot commented Nov 8, 2023

tekton-robot commented Nov 9, 2023

tekton-robot commented Nov 9, 2023

jerop left a comment

Choose a reason for hiding this comment

chitrangpatel commented Nov 3, 2023 •

edited

Loading