Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy in the ConsolePlugin #2545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pratap0007
Copy link
Contributor

This patch adds a proxy to result api server in pipelines-console-plugin
in order to send Authorization headers to Results API

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

This adds a proxy to result api server in pipelines-console-plugin 
in order to send Authorization headers to Results API

This patch adds a proxy to result api server in pipelines-console-plugin
in order to send Authorization headers to Results API

Signed-off-by: Shiv Verma <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 29, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign puneetpunamiya after the PR has been reviewed.
You can assign the PR to them by writing /assign @puneetpunamiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2025
@jkhelil
Copy link
Member

jkhelil commented Jan 31, 2025

@khrm can you check this please ?

@jkhelil
Copy link
Member

jkhelil commented Feb 3, 2025

/approve

@khrm
Copy link
Contributor

khrm commented Feb 6, 2025

We can merge this after checking with console-plugin image utilizing proxy.
/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants