Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Oauth2.0 integration #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ManindraDeMel
Copy link

This PR updates the email alert system used in main.py. #15

Previously, an outdated mail_alert function was in place. This function has been commented out in favor of a more streamlined and efficient implementation. The new system utilizes two new functions, create_message and send_message, that have been defined in the mail module.

Key changes include:

  1. Replacement of old mail_alert function: The mail_alert function was commented out and replaced with the create_message and send_message functions. This refactoring simplifies the process of creating and sending email alerts.

  2. Improved error handling: The new system uses Google's HttpError for more robust error handling during the message creation and sending process.

  3. Streamlined function usage: The alert_user function has been introduced, which internally uses create_message and send_message to send email alerts. This allows for cleaner function calls in the main code.

Please review the changes and let me know if there are any issues or suggestions. This update aims to improve the maintainability and efficiency of the email alert system in main.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant