fix some phpstan issues

teamneusta · Jan 2, 2024 · 780962a · 780962a
1 parent fbc3419
commit 780962a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 11 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -15,16 +15,6 @@ parameters:
 			count: 1
 			path: src/Command/LoadFixturesCommand.php
 
-		-
-			message: "#^Method Neusta\\\\Pimcore\\\\FixtureBundle\\\\DependencyInjection\\\\NeustaPimcoreFixtureExtension\\:\\:loadInternal\\(\\) has parameter \\$mergedConfig with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: src/DependencyInjection/NeustaPimcoreFixtureExtension.php
-
-		-
-			message: "#^Method Neusta\\\\Pimcore\\\\FixtureBundle\\\\Documents\\\\Model\\\\EditableConfig\\:\\:__construct\\(\\) has parameter \\$data with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: src/Documents/Model/EditableConfig.php
-
 		-
 			message: "#^Call to an undefined method Pimcore\\\\Db\\\\ConnectionInterface\\:\\:getConfiguration\\(\\)\\.$#"
 			count: 3

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -15,7 +15,7 @@
         <ini name="display_errors" value="On"/>
         <ini name="error_reporting" value="-1"/>
         <env name="KERNEL_CLASS" value="TestKernel"/>
-        <env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled" />
+        <env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled"/>
     </php>
 
     <testsuites>

diff --git a/src/DependencyInjection/NeustaPimcoreFixtureExtension.php b/src/DependencyInjection/NeustaPimcoreFixtureExtension.php
@@ -14,6 +14,9 @@
 
 class NeustaPimcoreFixtureExtension extends ConfigurableExtension
 {
+    /**
+     * @param array<string, mixed> $mergedConfig
+     */
     protected function loadInternal(array $mergedConfig, ContainerBuilder $container): void
     {
         $loader = new YamlFileLoader($container, new FileLocator(\dirname(__DIR__, 2) . '/config'));

diff --git a/src/Documents/Model/EditableConfig.php b/src/Documents/Model/EditableConfig.php
@@ -5,6 +5,9 @@
 
 class EditableConfig
 {
+    /**
+     * @param string|array<string> $data
+     */
     public function __construct(
         public string $type,
         public string $name,