fix: remove lottie to enable build again #161 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for btcmap pending review.Visit the deploys page to approve it
|
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@lottiefiles/[email protected], npm/[email protected] |
|
💁♂️ @bubelov |
|
I'm fine with removing animations if it doesn't break anything. Being able to build an app is clearly more important |
|
To be honest, due to the state of the app I couldn't check how it used to look like. Happy to continue with cleaning up deps and setup. |
|
I tested boosts and they're still working in this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR address a related issue?
#161
A description of the changes proposed in the pull request
Build was failing due to outdated and unmaintained dep.
TS errors were already ignored before but now it's just breaking.
Additional context
If you're ok with leaving out these animations for now we're good. If not a different solution needs to be discussed maybe.