Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for "iterator helpers close receiver on argument validation failure" #4350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
// Copyright (C) 2024 Kevin Gibbons. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorprototype.drop
description: >
Underlying iterator is closed when argument validation fails
info: |
%Iterator.prototype%.drop ( limit )

features: [iterator-helpers]
flags: []
---*/

let closed = false;
let closable = {
__proto__: Iterator.prototype,
get next() {
throw new Test262Error('next should not be read');
},
return() {
closed = true;
},
};

assert.throws(RangeError, function() {
closable.drop();
});
assert.sameValue(closed, true);

closed = false;
assert.throws(RangeError, function() {
closable.drop(NaN);
});
assert.sameValue(closed, true);

closed = false;
assert.throws(RangeError, function() {
closable.drop(-1);
});
assert.sameValue(closed, true);

closed = false;
assert.throws(Test262Error, function() {
closable.drop({ get valueOf() { throw new Test262Error(); }});
});
assert.sameValue(closed, true);
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright (C) 2024 Kevin Gibbons. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorprototype.every
description: >
Underlying iterator is closed when argument validation fails
info: |
%Iterator.prototype%.every ( predicate )

features: [iterator-helpers]
flags: []
---*/

let closed = false;
let closable = {
__proto__: Iterator.prototype,
get next() {
throw new Test262Error('next should not be read');
},
return() {
closed = true;
},
};

assert.throws(TypeError, function() {
closable.every();
});
assert.sameValue(closed, true);

closed = false;
assert.throws(TypeError, function() {
closable.every({});
});
assert.sameValue(closed, true);
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright (C) 2024 Kevin Gibbons. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorprototype.filter
description: >
Underlying iterator is closed when argument validation fails
info: |
%Iterator.prototype%.filter ( predicate )

features: [iterator-helpers]
flags: []
---*/

let closed = false;
let closable = {
__proto__: Iterator.prototype,
get next() {
throw new Test262Error('next should not be read');
},
return() {
closed = true;
},
};

assert.throws(TypeError, function() {
closable.filter();
});
assert.sameValue(closed, true);

closed = false;
assert.throws(TypeError, function() {
closable.filter({});
});
assert.sameValue(closed, true);
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright (C) 2024 Kevin Gibbons. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorprototype.find
description: >
Underlying iterator is closed when argument validation fails
info: |
%Iterator.prototype%.find ( predicate )

features: [iterator-helpers]
flags: []
---*/

let closed = false;
let closable = {
__proto__: Iterator.prototype,
get next() {
throw new Test262Error('next should not be read');
},
return() {
closed = true;
},
};

assert.throws(TypeError, function() {
closable.find();
});
assert.sameValue(closed, true);

closed = false;
assert.throws(TypeError, function() {
closable.find({});
});
assert.sameValue(closed, true);
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright (C) 2024 Kevin Gibbons. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorprototype.flatMap
description: >
Underlying iterator is closed when argument validation fails
info: |
%Iterator.prototype%.flatMap ( mapper )

features: [iterator-helpers]
flags: []
---*/

let closed = false;
let closable = {
__proto__: Iterator.prototype,
get next() {
throw new Test262Error('next should not be read');
},
return() {
closed = true;
},
};

assert.throws(TypeError, function() {
closable.flatMap();
});
assert.sameValue(closed, true);

closed = false;
assert.throws(TypeError, function() {
closable.flatMap({});
});
assert.sameValue(closed, true);
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright (C) 2024 Kevin Gibbons. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorprototype.forEach
description: >
Underlying iterator is closed when argument validation fails
info: |
%Iterator.prototype%.forEach ( predicate )

features: [iterator-helpers]
flags: []
---*/

let closed = false;
let closable = {
__proto__: Iterator.prototype,
get next() {
throw new Test262Error('next should not be read');
},
return() {
closed = true;
},
};

assert.throws(TypeError, function() {
closable.forEach();
});
assert.sameValue(closed, true);

closed = false;
assert.throws(TypeError, function() {
closable.forEach({});
});
assert.sameValue(closed, true);
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright (C) 2024 Kevin Gibbons. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorprototype.map
description: >
Underlying iterator is closed when argument validation fails
info: |
%Iterator.prototype%.map ( mapper )

features: [iterator-helpers]
flags: []
---*/

let closed = false;
let closable = {
__proto__: Iterator.prototype,
get next() {
throw new Test262Error('next should not be read');
},
return() {
closed = true;
},
};

assert.throws(TypeError, function() {
closable.map();
});
assert.sameValue(closed, true);

closed = false;
assert.throws(TypeError, function() {
closable.map({});
});
assert.sameValue(closed, true);
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright (C) 2024 Kevin Gibbons. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorprototype.reduce
description: >
Underlying iterator is closed when argument validation fails
info: |
%Iterator.prototype%.reduce ( reducer, [ initialValue ] )

features: [iterator-helpers]
flags: []
---*/

let closed = false;
let closable = {
__proto__: Iterator.prototype,
get next() {
throw new Test262Error('next should not be read');
},
return() {
closed = true;
},
};

assert.throws(TypeError, function() {
closable.reduce();
});
assert.sameValue(closed, true);

closed = false;
assert.throws(TypeError, function() {
closable.reduce({});
});
assert.sameValue(closed, true);
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright (C) 2024 Kevin Gibbons. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorprototype.some
description: >
Underlying iterator is closed when argument validation fails
info: |
%Iterator.prototype%.some ( predicate )

features: [iterator-helpers]
flags: []
---*/

let closed = false;
let closable = {
__proto__: Iterator.prototype,
get next() {
throw new Test262Error('next should not be read');
},
return() {
closed = true;
},
};

assert.throws(TypeError, function() {
closable.some();
});
assert.sameValue(closed, true);

closed = false;
assert.throws(TypeError, function() {
closable.some({});
});
assert.sameValue(closed, true);
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
// Copyright (C) 2024 Kevin Gibbons. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-iteratorprototype.take
description: >
Underlying iterator is closed when argument validation fails
info: |
%Iterator.prototype%.take ( limit )

features: [iterator-helpers]
flags: []
---*/

let closed = false;
let closable = {
__proto__: Iterator.prototype,
get next() {
throw new Test262Error('next should not be read');
},
return() {
closed = true;
},
};

assert.throws(RangeError, function() {
closable.take();
});
Comment on lines +20 to +27
Copy link
Contributor

@sosukesuzuki sosukesuzuki Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the return value of return is not an object, wouldn't TypeError be thrown before RangeError due to step 7 of IteratorClose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Iterator#map and Iterator#filter, etc pass the tests, but they probably do not behave as intended. In all tests, the return method of closable should return an object, I think.

assert.sameValue(closed, true);

closed = false;
assert.throws(RangeError, function() {
closable.take(NaN);
});
assert.sameValue(closed, true);

closed = false;
assert.throws(RangeError, function() {
closable.take(-1);
});
assert.sameValue(closed, true);

closed = false;
assert.throws(Test262Error, function() {
closable.take({ get valueOf() { throw new Test262Error(); }});
});
assert.sameValue(closed, true);
Loading