Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer feedback #45

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Reviewer feedback #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fdadbd
editorial: notes adjustments from review
guybedford Dec 3, 2024
dc33288
rebuild
guybedford Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions build/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2696,7 +2696,7 @@
</ul></div><div id="menu-toggle"><svg xmlns="http://www.w3.org/2000/svg" style="width:100%; height:100%; stroke:currentColor" viewBox="0 0 120 120">
<title>Menu</title>
<path stroke-width="10" stroke-linecap="round" d="M30,60 h60 M30,30 m0,5 h60 M30,90 m0,-5 h60"></path>
</svg></div><div id="menu-spacer" class="menu-spacer"></div><div id="menu"><div id="menu-search"><input type="text" id="menu-search-box" placeholder="Search..."><div id="menu-search-results" class="inactive"></div></div><div id="menu-pins"><div class="menu-pane-header">Pins</div><ul id="menu-pins-list"></ul></div><div class="menu-pane-header">Table of Contents</div><div id="menu-toc"><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-ecmascript-data-types-and-values" title="ECMAScript Data Types and Values"><span class="secnum">1</span> ECMAScript Data Types and Values</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-ecmascript-language-types" title="ECMAScript Language Types"><span class="secnum">1.1</span> ECMAScript Language Types</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-object-type" title="Object Type"><span class="secnum">1.1.1</span> Object Type</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-well-known-intrinsic-objects" title="Well-Known Intrinsic Objects"><span class="secnum">1.1.1.1</span> Well-Known Intrinsic Objects</a></li></ol></li></ol></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-ecmascript-language-expressions" title="ECMAScript Language: Expressions"><span class="secnum">13</span> ECMAScript Language: Expressions</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-left-hand-side-expressions" title="Left-Hand-Side Expressions"><span class="secnum">13.3</span> Left-Hand-Side Expressions</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-import-calls" title="Import Calls"><span class="secnum">13.3.10</span> Import Calls</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-evaluate-import-call" title="EvaluateImportCall ( specifierExpression, phase [ , optionsExpression ] )"><span class="secnum">13.3.10.1</span> EvaluateImportCall ( <var>specifierExpression</var>, <var>phase</var> [ , <var>optionsExpression</var> ] )</a></li></ol></li></ol></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-ecmascript-language-scripts-and-modules" title="ECMAScript Language: Scripts and Modules"><span class="secnum">16</span> ECMAScript Language: Scripts and Modules</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-modules" title="Modules"><span class="secnum">16.1</span> Modules</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-module-semantics" title="Module Semantics"><span class="secnum">16.1.1</span> Module Semantics</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-abstract-module-records" title="Abstract Module Records"><span class="secnum">16.1.1.1</span> Abstract Module Records</a></li><li><span class="item-toggle">◢</span><a href="#sec-source-text-module-records" title="Source Text Module Records"><span class="secnum">16.1.1.2</span> Source Text Module Records</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-parsemodule" title="ParseModule ( sourceText, realm, hostDefined )"><span class="secnum">16.1.1.2.1</span> ParseModule ( <var>sourceText</var>, <var>realm</var>, <var>hostDefined</var> )</a></li><li><span class="item-toggle-none"></span><a href="#sec-source-text-module-record-getmodulesource" title="GetModuleSource ( )"><span class="secnum">16.1.1.2.2</span> GetModuleSource ( )</a></li><li><span class="item-toggle-none"></span><a href="#sec-source-text-module-record-sourceequals" title="ModuleSourcesEqual ( otherModule )"><span class="secnum">16.1.1.2.3</span> <ins>ModuleSourcesEqual ( <var>otherModule</var> )</ins></a></li><li><span class="item-toggle-none"></span><a href="#sec-source-text-module-record-getmodulesourcename" title="GetModuleSourceKind ( )"><span class="secnum">16.1.1.2.4</span> <ins>GetModuleSourceKind ( )</ins></a></li><li><span class="item-toggle-none"></span><a href="#sec-HostLoadImportedModule" title="HostLoadImportedModule ( referrer, moduleRequest, hostDefined, payload )"><span class="secnum">16.1.1.2.5</span> HostLoadImportedModule ( <var>referrer</var>, <var>moduleRequest</var>, <var>hostDefined</var>, <var>payload</var> )</a></li><li><span class="item-toggle-none"></span><a href="#sec-FinishLoadingImportedModule" title="FinishLoadingImportedModule ( referrer, moduleRequest, payload, result )"><span class="secnum">16.1.1.2.6</span> FinishLoadingImportedModule ( <var>referrer</var>, <var>moduleRequest</var>, <var>payload</var>, <var>result</var> )</a></li></ol></li><li><span class="item-toggle-none"></span><a href="#sec-getmodulesourcemodulerecord" title="GetModuleSourceModuleRecord ( specifier )"><span class="secnum">16.1.1.3</span> <ins>GetModuleSourceModuleRecord ( <var>specifier</var> )</ins></a></li><li><span class="item-toggle-none"></span><a href="#sec-HostGetModuleSourceName" title="HostGetModuleSourceName ( moduleSource )"><span class="secnum">16.1.1.4</span> <del>HostGetModuleSourceName ( <var>moduleSource</var> )</del></a></li><li><span class="item-toggle-none"></span><a href="#sec-HostGetModuleSourceModuleRecord" title="HostGetModuleSourceModuleRecord ( specifier )"><span class="secnum">16.1.1.5</span> <ins>HostGetModuleSourceModuleRecord ( <var>specifier</var> )</ins></a></li></ol></li></ol></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-reflection" title="Reflection"><span class="secnum">28</span> Reflection</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-module-source-objects" title="Module Source Objects"><span class="secnum">28.1</span> Module Source Objects</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-properties-of-the-%abstractmodulesource%-prototype-object" title="Properties of the %AbstractModuleSource% Prototype Object"><span class="secnum">28.1.1</span> Properties of the %AbstractModuleSource% Prototype Object</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-get-%abstractmodulesource%.prototype-%symbol.tostringtag%" title="get %AbstractModuleSource%.prototype [ %Symbol.toStringTag% ]"><span class="secnum">28.1.1.1</span> get %AbstractModuleSource%.prototype [ %Symbol.toStringTag% ]</a></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-module-source-object" title="The ModuleSource Constructor"><span class="secnum">28.1.2</span> <ins>The ModuleSource Constructor</ins></a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-modulesource" title="ModuleSource ( )"><span class="secnum">28.1.2.1</span> ModuleSource ( )</a></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-properties-of-the-%modulesource%-prototype-object" title="Properties of the %ModuleSource% Prototype Object"><span class="secnum">28.1.3</span> <ins>Properties of the %ModuleSource% Prototype Object</ins></a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-%modulesource%.prototype.constructor" title="%ModuleSource%.prototype.constructor"><span class="secnum">28.1.3.1</span> <ins>%ModuleSource%.prototype.constructor</ins></a></li></ol></li><li><span class="item-toggle-none"></span><a href="#sec-properties-of-modulesource-instances" title="Properties of ModuleSource Instances"><span class="secnum">28.1.4</span> <ins>Properties of ModuleSource Instances</ins></a></li></ol></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-host-layering-points" title="Host Layering Points"><span class="secnum">A</span> Host Layering Points</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-host-hooks-summary" title="Host Hooks"><span class="secnum">A.1</span> Host Hooks</a></li></ol></li><li><span class="item-toggle-none"></span><a href="#sec-copyright-and-software-license" title="Copyright &amp; Software License"><span class="secnum">B</span> Copyright &amp; Software License</a></li></ol></div></div><div id="spec-container"><h1 class="version">Stage 2 Draft / December 1, 2024</h1><h1 class="title">ECMAScript Module Phase Imports</h1>
</svg></div><div id="menu-spacer" class="menu-spacer"></div><div id="menu"><div id="menu-search"><input type="text" id="menu-search-box" placeholder="Search..."><div id="menu-search-results" class="inactive"></div></div><div id="menu-pins"><div class="menu-pane-header">Pins</div><ul id="menu-pins-list"></ul></div><div class="menu-pane-header">Table of Contents</div><div id="menu-toc"><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-ecmascript-data-types-and-values" title="ECMAScript Data Types and Values"><span class="secnum">1</span> ECMAScript Data Types and Values</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-ecmascript-language-types" title="ECMAScript Language Types"><span class="secnum">1.1</span> ECMAScript Language Types</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-object-type" title="Object Type"><span class="secnum">1.1.1</span> Object Type</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-well-known-intrinsic-objects" title="Well-Known Intrinsic Objects"><span class="secnum">1.1.1.1</span> Well-Known Intrinsic Objects</a></li></ol></li></ol></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-ecmascript-language-expressions" title="ECMAScript Language: Expressions"><span class="secnum">13</span> ECMAScript Language: Expressions</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-left-hand-side-expressions" title="Left-Hand-Side Expressions"><span class="secnum">13.3</span> Left-Hand-Side Expressions</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-import-calls" title="Import Calls"><span class="secnum">13.3.10</span> Import Calls</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-evaluate-import-call" title="EvaluateImportCall ( specifierExpression, phase [ , optionsExpression ] )"><span class="secnum">13.3.10.1</span> EvaluateImportCall ( <var>specifierExpression</var>, <var>phase</var> [ , <var>optionsExpression</var> ] )</a></li></ol></li></ol></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-ecmascript-language-scripts-and-modules" title="ECMAScript Language: Scripts and Modules"><span class="secnum">16</span> ECMAScript Language: Scripts and Modules</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-modules" title="Modules"><span class="secnum">16.1</span> Modules</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-module-semantics" title="Module Semantics"><span class="secnum">16.1.1</span> Module Semantics</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-abstract-module-records" title="Abstract Module Records"><span class="secnum">16.1.1.1</span> Abstract Module Records</a></li><li><span class="item-toggle">◢</span><a href="#sec-source-text-module-records" title="Source Text Module Records"><span class="secnum">16.1.1.2</span> Source Text Module Records</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-parsemodule" title="ParseModule ( sourceText, realm, hostDefined )"><span class="secnum">16.1.1.2.1</span> ParseModule ( <var>sourceText</var>, <var>realm</var>, <var>hostDefined</var> )</a></li><li><span class="item-toggle-none"></span><a href="#sec-source-text-module-record-getmodulesource" title="GetModuleSource ( )"><span class="secnum">16.1.1.2.2</span> GetModuleSource ( )</a></li><li><span class="item-toggle-none"></span><a href="#sec-source-text-module-record-sourceequals" title="ModuleSourcesEqual ( otherModule )"><span class="secnum">16.1.1.2.3</span> <ins>ModuleSourcesEqual ( <var>otherModule</var> )</ins></a></li><li><span class="item-toggle-none"></span><a href="#sec-source-text-module-record-getmodulesourcename" title="GetModuleSourceKind ( )"><span class="secnum">16.1.1.2.4</span> <ins>GetModuleSourceKind ( )</ins></a></li><li><span class="item-toggle-none"></span><a href="#sec-HostLoadImportedModule" title="HostLoadImportedModule ( referrer, moduleRequest, hostDefined, payload )"><span class="secnum">16.1.1.2.5</span> HostLoadImportedModule ( <var>referrer</var>, <var>moduleRequest</var>, <var>hostDefined</var>, <var>payload</var> )</a></li><li><span class="item-toggle-none"></span><a href="#sec-FinishLoadingImportedModule" title="FinishLoadingImportedModule ( referrer, moduleRequest, payload, result )"><span class="secnum">16.1.1.2.6</span> FinishLoadingImportedModule ( <var>referrer</var>, <var>moduleRequest</var>, <var>payload</var>, <var>result</var> )</a></li></ol></li><li><span class="item-toggle-none"></span><a href="#sec-getmodulesourcemodulerecord" title="GetModuleSourceModuleRecord ( specifier )"><span class="secnum">16.1.1.3</span> <ins>GetModuleSourceModuleRecord ( <var>specifier</var> )</ins></a></li><li><span class="item-toggle-none"></span><a href="#sec-HostGetModuleSourceName" title="HostGetModuleSourceName ( moduleSource )"><span class="secnum">16.1.1.4</span> <del>HostGetModuleSourceName ( <var>moduleSource</var> )</del></a></li><li><span class="item-toggle-none"></span><a href="#sec-HostGetModuleSourceModuleRecord" title="HostGetModuleSourceModuleRecord ( specifier )"><span class="secnum">16.1.1.5</span> <ins>HostGetModuleSourceModuleRecord ( <var>specifier</var> )</ins></a></li></ol></li></ol></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-reflection" title="Reflection"><span class="secnum">28</span> Reflection</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-module-source-objects" title="Module Source Objects"><span class="secnum">28.1</span> Module Source Objects</a><ol class="toc"><li><span class="item-toggle">◢</span><a href="#sec-properties-of-the-%abstractmodulesource%-prototype-object" title="Properties of the %AbstractModuleSource% Prototype Object"><span class="secnum">28.1.1</span> Properties of the %AbstractModuleSource% Prototype Object</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-get-%abstractmodulesource%.prototype-%symbol.tostringtag%" title="get %AbstractModuleSource%.prototype [ %Symbol.toStringTag% ]"><span class="secnum">28.1.1.1</span> get %AbstractModuleSource%.prototype [ %Symbol.toStringTag% ]</a></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-module-source-object" title="The ModuleSource Constructor"><span class="secnum">28.1.2</span> <ins>The ModuleSource Constructor</ins></a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-modulesource" title="ModuleSource ( )"><span class="secnum">28.1.2.1</span> ModuleSource ( )</a></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-properties-of-the-%modulesource%-prototype-object" title="Properties of the %ModuleSource% Prototype Object"><span class="secnum">28.1.3</span> <ins>Properties of the %ModuleSource% Prototype Object</ins></a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-%modulesource%.prototype.constructor" title="%ModuleSource%.prototype.constructor"><span class="secnum">28.1.3.1</span> <ins>%ModuleSource%.prototype.constructor</ins></a></li></ol></li><li><span class="item-toggle-none"></span><a href="#sec-properties-of-modulesource-instances" title="Properties of ModuleSource Instances"><span class="secnum">28.1.4</span> <ins>Properties of ModuleSource Instances</ins></a></li></ol></li></ol></li><li><span class="item-toggle">◢</span><a href="#sec-host-layering-points" title="Host Layering Points"><span class="secnum">A</span> Host Layering Points</a><ol class="toc"><li><span class="item-toggle-none"></span><a href="#sec-host-hooks-summary" title="Host Hooks"><span class="secnum">A.1</span> Host Hooks</a></li></ol></li><li><span class="item-toggle-none"></span><a href="#sec-copyright-and-software-license" title="Copyright &amp; Software License"><span class="secnum">B</span> Copyright &amp; Software License</a></li></ol></div></div><div id="spec-container"><h1 class="version">Stage 2 Draft / December 3, 2024</h1><h1 class="title">ECMAScript Module Phase Imports</h1>

<emu-clause id="sec-ecmascript-data-types-and-values" aoid="Type">
<h1><span class="secnum">1</span> ECMAScript Data Types and Values</h1>
Expand Down Expand Up @@ -3761,7 +3761,7 @@ <h1><span class="secnum">16.1.1.2.3</span> <ins>ModuleSourcesEqual ( <var>otherM

<emu-note><span class="note">Note</span><div class="note-contents">
<p>Despite not being called from ECMA-262, ModuleSourcesEqual defines a <emu-xref href="#host"><a href="https://tc39.es/ecma262/#host">host</a></emu-xref> equality definition needed in <emu-xref aoid="HostLoadImportedModule" id="_ref_24"><a href="#sec-HostLoadImportedModule">HostLoadImportedModule</a></emu-xref> for <emu-xref href="#sourctextmodule-record"><a href="https://tc39.es/ecma262/#sourctextmodule-record">Source Text Module Record</a></emu-xref>.</p>
<p>It is also the only use of the <var class="field">[[SourceText]]</var> field as providing for this equality checking, distinct from the <var class="field">[[EcmaScriptCode]]</var> field.</p>
<p>The <var class="field">[[SourceText]]</var> field is only used to define source text equality and serialization.</p>
</div></emu-note>
</emu-clause>

Expand Down Expand Up @@ -3869,7 +3869,8 @@ <h1><span class="secnum">16.1.1.5</span> <ins>HostGetModuleSourceModuleRecord (
<h1><span class="secnum">28</span> Reflection</h1>
<emu-clause id="sec-module-source-objects">
<h1><span class="secnum">28.1</span> Module Source Objects</h1>
<p>Module Source Objects represent modules in their source import phase, which are not linked, instantiated or executed.</p>
<p><del>Module Source Objects represent modules in their source import phase, which are not linked, instantiated or executed.</del></p>
<p><ins>Module Source Objects represent the immutable data associated with a module record, distinct from linking, instantiation or execution state.</ins></p>
<p>A <dfn>Module Source Object</dfn> is an object for which <del><emu-xref aoid="HostGetModuleSourceName" id="_ref_49"><a href="#sec-HostGetModuleSourceName">HostGetModuleSourceName</a></emu-xref></del><ins><emu-xref aoid="GetModuleSourceModuleRecord" id="_ref_50"><a href="#sec-getmodulesourcemodulerecord">GetModuleSourceModuleRecord</a></emu-xref></ins> returns a <emu-xref href="#sec-completion-record-specification-type"><a href="https://tc39.es/ecma262/#sec-completion-record-specification-type">normal completion</a></emu-xref>.</p>
<p>All Module Source Objects should have a prototype of %AbstractModuleSource%.prototype.</p>
<p><emu-xref href="#host"><a href="https://tc39.es/ecma262/#host">Hosts</a></emu-xref> may define their own %AbstractModuleSource% subclasses for custom module types.</p>
Expand Down
Loading
Loading