Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IsHTMLDDA should be a property, not a function #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions runtimes/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,7 @@ var $262 = window.$262 = {
destroy() {
$262.socket.emit('destroy')
},
IsHTMLDDA() {
return document.all;
},
IsHTMLDDA: document.all,
source: $SOURCE
};

Expand Down
2 changes: 1 addition & 1 deletion runtimes/chakra.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ var $262 = {
this.global[name] = value;
},
destroy() { /* noop */ },
IsHTMLDDA() { return {}; },
IsHTMLDDA: {},
source: $SOURCE,
agent: (function() {
const isAgentSupportable = WScript.Broadcast && WScript.ReceiveBroadcast &&
Expand Down
2 changes: 1 addition & 1 deletion runtimes/d8.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var $262 = {
this.global[name] = value;
},
destroy() { /* noop */ },
IsHTMLDDA() { return {}; },
IsHTMLDDA: {},
source: $SOURCE,
realm: Realm.current(),
detachArrayBuffer(buffer) {
Expand Down
2 changes: 1 addition & 1 deletion runtimes/graaljs.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ $262.setGlobal = function(name, value) {
this.global[name] = value;
};
$262.destroy = function () { /* noop */ };
$262.IsHTMLDDA = function() { return {}; };
$262.IsHTMLDDA = {};
$262.source = $SOURCE;

$262.evalScript = function(code) {
Expand Down
2 changes: 1 addition & 1 deletion runtimes/hermes.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var $262 = {
this.global[name] = value;
},
destroy() { /* noop */ },
IsHTMLDDA() { return {}; },
IsHTMLDDA: {},
source: $SOURCE,
get agent() {
throw new Test262Error('agent.* not yet supported.');
Expand Down
2 changes: 1 addition & 1 deletion runtimes/jsc.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,5 @@ $262.createRealm = function (options = {}) {


if (!$262.IsHTMLDDA) {
$262.IsHTMLDDA = function() { return {}; };
$262.IsHTMLDDA = {};
}
2 changes: 1 addition & 1 deletion runtimes/jsshell.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var $262 = {
this.global[name] = value;
},
destroy() { /* noop */ },
IsHTMLDDA() {
get IsHTMLDDA() {
/* objectEmulatingUndefined was replaced by createIsHTMLDDA in newer SpiderMonkey builds. */
if (typeof createIsHTMLDDA === 'function') {
return createIsHTMLDDA();
Expand Down
2 changes: 1 addition & 1 deletion runtimes/nashorn.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ var $262 = {
this.global[name] = value;
},
destroy: function() { /* noop */ },
IsHTMLDDA: function() { return {}; },
IsHTMLDDA: {},
source: $SOURCE,
agent: (function() {
function thrower() {
Expand Down
2 changes: 1 addition & 1 deletion runtimes/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ var $262 = {
this.global[name] = value;
},
destroy() { /* noop */ },
IsHTMLDDA() { return {}; },
IsHTMLDDA: {},
source: $SOURCE
};

Expand Down
2 changes: 1 addition & 1 deletion runtimes/xs.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ if (!$262) {
})(),
};
}
$262.IsHTMLDDA = function() {};
$262.IsHTMLDDA = {};
$262.destroy = function() {};
$262.getGlobal = function(name) {
return this.global[name];
Expand Down