Editorial: Model CaptureRange and MatchState as Records #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Oct 17, 2023
bakkot
reviewed
Oct 17, 2023
spec.html
Outdated
| @@ -36660,11 +36660,11 @@ <h1> | |||
| 1. Return _y_. | |||
| 1. Let _r_ be _m_(_x_, _d_). | |||
| 1. If _r_ is ~failure~, return ~failure~. | |||
| 1. Let _y_ be _r_'s MatchState. | |||
There was a problem hiding this comment.
Oh jeeze, I'd never noticed this before. I have no idea how this was supposed to make sense.
bakkot
approved these changes
Oct 17, 2023
bakkot
added
editor call
zhangenming
pushed a commit
to zhangenming/ecma262
that referenced
this pull request
Dec 22, 2023
zhangenming
pushed a commit
to zhangenming/ecma262
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the last bit of "making RegExps consistent with rest of ecma262" (from the 'Upcoming Editorial Work' slide).
Note: CaptureRange and Match Record have the same structure, though slightly different uses. I wonder if we should either merge them or rename them (in a way that acknowledges their similarity and their difference).