Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change MSRV check to use 1.84 resolver #12401

Merged
merged 12 commits into from
Jan 14, 2025
Merged

ci: Change MSRV check to use 1.84 resolver #12401

merged 12 commits into from
Jan 14, 2025

Conversation

FabianLars
Copy link
Member

@amrbashir pinging you because back when i changed the msrv stuff and committed the lockfile you wanted to keep this check around, are you okay with this change?

@FabianLars FabianLars requested a review from a team as a code owner January 14, 2025 16:25
Copy link
Contributor

Package Changes Through d671fcd

No changes.

Add a change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully soon we won't need this MSRV check anymore

@FabianLars
Copy link
Member Author

one can dream :D

@FabianLars FabianLars merged commit 6de7415 into 1.x Jan 14, 2025
22 checks passed
@FabianLars FabianLars deleted the v1/msrv-check branch January 14, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants