pkp/pkp-lib#10759 Store ORCID's review work put code in

review_assignment table
taslangraham · Jan 7, 2025 · 451483b · 451483b
1 parent 76677a4
commit 451483b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/dbscripts/xml/install.xml b/dbscripts/xml/install.xml
@@ -47,6 +47,7 @@
 	<migration class="PKP\migration\install\CategoriesMigration" />
 	<migration class="PKP\migration\install\HighlightsMigration" />
 	<migration class="APP\migration\install\MetricsMigration" />
+	<migration class="PKP\migration\install\ReviewAssignmentSettings" />
 
 	<!-- Other install tasks -->
 	<code function="createData"/>

diff --git a/dbscripts/xml/upgrade.xml b/dbscripts/xml/upgrade.xml
@@ -157,6 +157,7 @@
 		<migration class="PKP\migration\upgrade\v3_5_0\I10292_RemoveControlledVocabEntrySettingType"/>
 		<migration class="PKP\migration\upgrade\v3_5_0\I10292_UpdateControlledVocabAssocId"/>
 		<migration class="PKP\migration\upgrade\v3_5_0\I10292_UpdateControlledVocabEntrySettingName"/>
+		<migration class="PKP\migration\upgrade\v3_5_0\I10759_AddReviewAssignmentSettings"/>
 	</upgrade>
 
 	<!-- update plugin configuration - should be done as the final upgrade task -->

diff --git a/jobs/orcid/DepositOrcidReview.php b/jobs/orcid/DepositOrcidReview.php
@@ -71,7 +71,7 @@ public function handle(): void
 
                 $uri = OrcidManager::getApiPath($context) . OrcidManager::ORCID_API_VERSION_URL . $orcid . '/' . OrcidManager::ORCID_REVIEW_URL;
                 $method = 'POST';
-                if ($putCode = $reviewer->getData('orcidReviewPutCode')) {
+                if ($putCode = $reviewAssignment->getData('orcidReviewPutCode')) {
                     $uri .= '/' . $putCode;
                     $method = 'PUT';
                     $orcidReview['put-code'] = $putCode;
@@ -101,11 +101,11 @@ public function handle(): void
                             OrcidManager::logInfo("Review updated in profile, putCode: {$putCode}");
                             break;
                         case 201:
-                            $location = $responseHeaders['Location'][0];
+                            $location = $responseHeaders['location'][0];
                             // Extract the ORCID work put code for updates/deletion.
                             $putCode = basename(parse_url($location, PHP_URL_PATH));
-                            $reviewer->setData('orcidReviewPutCode', $putCode);
-                            Repo::user()->edit($reviewer, ['orcidReviewPutCode']);
+                            $reviewAssignment->setData('orcidReviewPutCode', $putCode);
+                            Repo::reviewAssignment()->edit($reviewAssignment, ['orcidReviewPutCode']);
                             OrcidManager::logInfo("Review added to profile, putCode: {$putCode}");
                             break;
                         default: