-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add msys2 CI #366
add msys2 CI #366
Conversation
use wide strings with msys, since its windows and working without wstrings fails in some tests cases
CI failures are unrelated to this PR, macos-11 isn't available anymore as github runner, and the clang versions that fail are also not available anymore in the ubuntu runners 😓 |
I'll send a new PR fixing the CI by today later. |
@uilianries Any update? |
@ColinH Sorry, totally missed it. I'm going to check it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The CMake for this build will use Ninja by default.
Android build failed due a checksum mismatch, nothing related to this PR. Still, I would not block it due that failure.
Thank you @uilianries for your work ❤️ |
@ColinH would it be possible to have new release, since now mysys2 is fully supported and works again? |
The |
This adds a Msys2 CI.
I tested it in Msys2 Clang64 locally and fixed #365 too.
For that I also had to change some code, so that Msys2 uses windows wide string functions to open a file, otherwise it wouldn't work.