Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add msys2 CI #366

Merged
merged 3 commits into from
Sep 15, 2024
Merged

add msys2 CI #366

merged 3 commits into from
Sep 15, 2024

Conversation

Totto16
Copy link
Contributor

@Totto16 Totto16 commented Aug 11, 2024

This adds a Msys2 CI.

I tested it in Msys2 Clang64 locally and fixed #365 too.
For that I also had to change some code, so that Msys2 uses windows wide string functions to open a file, otherwise it wouldn't work.

use wide strings with msys, since its windows and working without wstrings fails in some tests cases
@Totto16
Copy link
Contributor Author

Totto16 commented Aug 11, 2024

CI failures are unrelated to this PR, macos-11 isn't available anymore as github runner, and the clang versions that fail are also not available anymore in the ubuntu runners 😓

@uilianries
Copy link
Member

I'll send a new PR fixing the CI by today later.

@ColinH
Copy link
Member

ColinH commented Sep 14, 2024

@uilianries Any update?

@uilianries
Copy link
Member

@ColinH Sorry, totally missed it. I'm going to check it now.

@uilianries
Copy link
Member

@ColinH Sorry the confusion, the PR #367 is the fix that I mentioned before. Just need a review to be merged.

@ColinH
Copy link
Member

ColinH commented Sep 14, 2024

Is #367 the only PR that we need to merge now? In other words, did you incorporate the MSYS2 fixes into #367?

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CMake for this build will use Ninja by default.

Android build failed due a checksum mismatch, nothing related to this PR. Still, I would not block it due that failure.

@uilianries
Copy link
Member

Is #367 the only PR that we need to merge now? In other words, did you incorporate the MSYS2 fixes into #367?

Yes, I rebased those changes via the commit 8171fc4

@ColinH ColinH merged commit f420443 into taocpp:main Sep 15, 2024
63 of 64 checks passed
@Totto16 Totto16 deleted the msys_support branch September 15, 2024 18:46
@Totto16
Copy link
Contributor Author

Totto16 commented Sep 15, 2024

Thank you @uilianries for your work ❤️

@Totto16
Copy link
Contributor Author

Totto16 commented Sep 15, 2024

@ColinH would it be possible to have new release, since now mysys2 is fully supported and works again?

@ColinH
Copy link
Member

ColinH commented Sep 16, 2024

The main branch already has some changes towards a PEGTL 4.0 which I'm otherwise working towards on the work branch; the 4.0 with MSYS2 support will be released when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

MSYS2 environment is not considered in tests
3 participants