feat: extended sinatra sample with application run #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxirmx
force-pushed
the
extend-sinatra-sampel
branch
6 times, most recently
from
8200aa2 to
bc46297
Compare
maxirmx
force-pushed
the
extend-sinatra-sampel
branch
from
bc46297 to
685bb63
Compare
ronaldtse
requested changes
Jul 27, 2024
| @@ -32,3 +32,27 @@ jobs: | |||
|
|
|||
| - name: Look around | |||
| run: ls -la | |||
|
|
|||
| - name: Start packaged Sinatra application | |||
There was a problem hiding this comment.
Please split the Sinatra tests (each sample's tests) into a separate workflow.
ronaldtse
approved these changes
Jul 27, 2024
|
Let’s just merge this first and consider a workflow split later. Thanks @maxirmx ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.