Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect owner and repo name for organization #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hampuslidin
Copy link

@hampuslidin hampuslidin commented Apr 5, 2021

This hopefully fixes #27. These are the first lines of Go code I have ever written, so apologies in advance if anything is totally out of the order!

@hampuslidin
Copy link
Author

I noticed now that this is almost completely wrong. The pjName is not the parameter we want to pass to getProjectCardsFromIssue(), since this is the project name and not the repository name. Maybe this could be simplified a bit, and just fetch the repository name from the issue event payload instead.

eventID, err = extractIssueID(payload)
errCheck(err)
projectCards, err = getProjectCardsFromIssue(ctx, client, payload.Issue, parentResource, parentName)

repoOwner, repoName, err := repoOwnerAndName(payload.Issue.RepositoryUrl)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea if this is the correct way to fetch this repository URL from the payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving cards in organization project does not work
1 participant